Re: [PATCH] Eagle and ADI 930 usb adsl modem driver

From: matthieu castet (castet.matthieu_at_free.fr)
Date: 11/06/05

  • Next message: Marcel Holtmann: "Re: Problem with the default IOSCHED" 
    Date:	Sun, 06 Nov 2005 19:44:10 +0100
To: unlisted-recipients: ;(no To-header on input)

    Hi Greg,

    matthieu castet wrote:

    >>> + *
    >>> + * This software is available to you under a choice of one of two
    >>> + * licenses. You may choose to be licensed under the terms of the GNU
    >>> + * General Public License (GPL) Version 2, available from the file
    >>> + * COPYING in the main directory of this source tree, or the
    >>> + * BSD license below:
    >>> + *
    >>> + * Redistribution and use in source and binary forms, with or without
    >>> + * modification, are permitted provided that the following conditions
    >>> + * are met:
    >>
    >>
    >>
    >> <snip> You don't need the whole GPL 2 copy here, just put the first
    >> paragraph you have before this one in.
    >>
    > The paragraph you quote is the BSD licence, and point 1 is :
    > Redistributions of source code must retain the above copyright
    > * notice unmodified, this list of conditions, and the following
    > * disclaimer
    >
    > So could I remove it ?
    >
    >
    >>
    >>> diff -rNu -x '*.ko*' -x '*.mod*' -x '*.o*'
    >>> linux-2.6.14/drivers/usb/atm.old/ueagle-atm.h
    >>> linux-2.6.14/drivers/usb/atm/ueagle-atm.h
    >>> --- linux-2.6.14/drivers/usb/atm.old/ueagle-atm.h 1970-01-01
    >>> 01:00:00.000000000 +0100
    >>> +++ linux-2.6.14/drivers/usb/atm/ueagle-atm.h 2005-10-30
    >>> 00:25:27.000000000 +0200
    >>
    >>
    >>
    >> Why do you need a header file for a single .c file?
    >>
    > I think it makes things cleaner. I even like the bsd style where there
    > is an header for reg (hardware values) and an other for val (driver
    > structures).
    >

    We patched our driver with the comments sent, but we still don't know
    what to do with this 2 points :
    - For the license stuff, all the dual bsd/gpl drivers I saw in the
    kernel tree have the complete bsd header.
    - For the header file I prefer a separate header file, but if Linux
    policy is to merge header and source file, that's fine.

    Regards,

    Matthieu
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Marcel Holtmann: "Re: Problem with the default IOSCHED"

    Relevant Pages

    • Compiler error creating managed c++ directx app
      ... I'm trying to create a simple program using managed C++ and DirectX. ... Here is the source code I am using: ... did you forget to include a header file? ... "Microsoft.DirectX" to References in Solution Explorer, ...
      (microsoft.public.win32.programmer.directx.managed)
    • Re: [Lit.] Buffer overruns
      ... #defining the symbols within the source code you control you can inhibit ... any preprocessor overrides of those symbols. ... I prefer that the conflict be ... You can even automate it by creating a header file such as define_C.h ...
      (sci.crypt)
    • Re: beginners questions
      ... # (I work on Linux 2.4.22/Debian) ... Some supply the source code, ... second #define converts them into old style K+R function declarations. ... use the same header file for two different styles of compilation. ...
      (comp.lang.c)
    • Re: Linux GPL and binary module exception clause?
      ... > | I didn't exactly specify how the interfacing would be done because that's ... > | with the proper structure offsets etc. ... > that reading the header file and then using absolute numbers isn't ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC][PATCH] Rename PageChecked as PageMiscFS
      ... Pavel Machek wrote: ... I disagree again. ... use (you can't rely on them going and looking in the header file for a ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)