Re: [Alsa-devel] Re: + v4l-720-alsa-support-for-saa7134-that-should-work-fix.patch added to -mm tree

From: Takashi Iwai (tiwai_at_suse.de)
Date: 11/07/05

  • Next message: Steven Timm: "RE: rpc-srv/tcp: nfsd: sent only -107 bytes (fwd)" 
    Date:	Mon, 07 Nov 2005 16:54:54 +0100
To: Lee Revell <rlrevell@joe-job.com>

    At Mon, 07 Nov 2005 10:33:35 -0500,
    Lee Revell wrote:
    >
    > On Mon, 2005-11-07 at 04:26 -0200, Mauro Carvalho Chehab wrote:
    > > Lee,
    > >
    > > Em Dom, 2005-11-06 ās 13:33 -0500, Lee Revell escreveu:
    > > > On Sun, 2005-11-06 at 00:12 -0800, Andrew Morton wrote:
    > > > > Well that didn't work. The problem is that
    > > > > drivers/media/video/saa7134/saa7134-alsa.c doesn't appear to be wired
    > > > > up into the build system - it simply doesn't get compiled.
    > > > >
    > > > > Please send a fix against next -mm?
    > > >
    > > > Also please send all ALSA related patches to
    > > > alsa-devel@lists.sourceforge.net for review.
    > >
    > > I'm sending you enclosed saa7134-alsa patch. To make easier to
    > > understand, I've merged all stuff. This is highly dependent of the other
    > > saa7134 parts, since PCI stuff are common to both video and audio
    > > funcion on this device.
    > > This is meant to replace saa7134-oss (after more tests) that,
    > > currently, is part of saa7134 module.
    >
    > OK, a brief review:
    >
    > - Why couldn't you use ALSA's DMA API?

    This is OK, IMO. Basically, it's up to the driver.

    > - The DMA must be stopped and started in the trigger callback, not the
    > prepare callback.
    >
    > - If this device lacks a volume control alsa-lib can emulate it in
    > software, just create a proper /usr/share/alsa/cards/your_card.conf
    > file.
    >
    > - By ALSA convention the acceptable formats, sample rates, etc should
    > be directly defined in the snd_pcm_hardware_t structure.
    >
    > - dev->oss needs to go.

    Agreed about the rest.

    Takashi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Steven Timm: "RE: rpc-srv/tcp: nfsd: sent only -107 bytes (fwd)"

    Relevant Pages

    • Re: [ANNOUNCE] Linux 2.6 Real Time Kernel
      ... Lee Revell writes: ... leaving all the default debug ... > options on, I got this debug output, but it did not coincide with the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch] voluntary-preempt-2.6.8-rc2-L2 PS2 keyboard gone south
      ... On Fri, 2004-07-30 at 23:57 -0400, Lee Revell wrote: ... This is my setup also, and I have had no problems since ... > installing M5. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Human tIming perception (was: RT patch)
      ... On Tue, 31 May 2005, Lee Revell wrote: ... Well MIDI runs at 31,250 bits/second or 3,906 bytes per second. ... 6-note chord. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] AES x86-64-asm impl.
      ... On Mon, 4 Oct 2004, Lee Revell wrote: ... >> Would you be happy if the code were wrapped as a general use package ... Jari's reasons are well documented. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] [CPU-HOTPLUG] convert cpucontrol to be a rwsem
      ... On Mon, 1 Nov 2004, Lee Revell wrote: ... ensuring that you run through that specific critical section without being ... interrupted by scheduling, this happens to also block out various things ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)