Re: [PATCH 4/4] Hugetlb: Copy on Write support

From: William Lee Irwin III (wli_at_holomorphy.com)
Date: 11/10/05

  • Next message: William Lee Irwin III: "Re: [PATCH 3/4] Hugetlb: Reorganize hugetlb_fault to prepare for COW"
    Date:	Wed, 9 Nov 2005 16:15:34 -0800
    To: Adam Litke <agl@us.ibm.com>
    
    

    On Wed, Nov 09, 2005 at 05:39:55PM -0600, Adam Litke wrote:
    > Hugetlb: Copy on Write support
    > Implement copy-on-write support for hugetlb mappings so MAP_PRIVATE can be
    > supported. This helps us to safely use hugetlb pages in many more
    > applications. The patch makes the following changes. If needed, I also have
    > it broken out according to the following paragraphs.
    > 1. Add a pair of functions to set/clear write access on huge ptes. The
    > writable check in make_huge_pte is moved out to the caller for use by COW
    > later.
    > 2. Hugetlb copy-on-write requires special case handling in the following
    > situations:
    > - copy_hugetlb_page_range() - Copied pages must be write protected so a COW
    > fault will be triggered (if necessary) if those pages are written to.
    > - find_or_alloc_huge_page() - Only MAP_SHARED pages are added to the page
    > cache. MAP_PRIVATE pages still need to be locked however.
    > 3. Provide hugetlb_cow() and calls from hugetlb_fault() and hugetlb_no_page()
    > which handles the COW fault by making the actual copy.
    > 4. Remove the check in hugetlbfs_file_map() so that MAP_PRIVATE mmaps will be
    > allowed. Make MAP_HUGETLB exempt from the depricated VM_RESERVED mapping
    > check.

    Did you do the audit of pte protection bits I asked about? If not, I'll
    dredge them up and check to make sure.

    -- wli
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: William Lee Irwin III: "Re: [PATCH 3/4] Hugetlb: Reorganize hugetlb_fault to prepare for COW"

    Relevant Pages

    • Re: [PATCH 4/4] Hugetlb: Copy on Write support
      ... Implement copy-on-write support for hugetlb mappings so MAP_PRIVATE can be ... which handles the COW fault by making the actual copy. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: compile fix 2.6.15-rc1-mm1 + EXPERIMENTAL+ CONFIG_SPARSEMEM + X86_PC
      ... > Please always include the text of the error messages when fixing compile ... # Firmware Drivers ... # ACPI Support ...
      (Linux-Kernel)
    • [PATCH] [0/18] GB pages hugetlb support
      ... This patchkit supports GB pages for hugetlb on x86-64 in addition to ... infrastructure to implement support for huge pages> MAX_ORDER ...
      (Linux-Kernel)
    • Re: swsusp: revert to 2.6.0-test3 state
      ... That would be a minimal patch. ... image of RAM, support for highmem, swap files, full asynchronous I/O, ... Nigel Cunningham ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Stop the Linux kernel madness
      ... We don't have the man power, hardware, nor the support ... "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)