Re: [PATCH 01/05] mm fix __alloc_pages cpuset ALLOC_* flags

From: Nick Piggin (nickpiggin_at_yahoo.com.au)
Date: 11/15/05

  • Next message: Nick Piggin: "Re: [patch 3/5] atomic: atomic_inc_not_zero" 
    Date:	Tue, 15 Nov 2005 19:52:20 +1100
To: Paul Jackson <pj@sgi.com>

    Paul Jackson wrote:
    > Two changes to the setting of the ALLOC_CPUSET flag in
    > mm/page_alloc.c:__alloc_pages()
    >
    > 1) A bug fix - the "ignoring mins" case should not be honoring
    > ALLOC_CPUSET. This case of all cases, since it is handling a
    > request that will free up more memory than is asked for (exiting
    > tasks, e.g.) should be allowed to escape cpuset constraints
    > when memory is tight.
    >
    > 2) A logic change to make it simpler. Honor cpusets even on
    > GFP_ATOMIC (!wait) requests. With this, cpuset confinement
    > applies to all requests except ALLOC_NO_WATERMARKS, so that
    > in a subsequent cleanup patch, I can remove the ALLOC_CPUSET
    > flag entirely. Since I don't know any real reason this
    > logic has to be either way, I am choosing the path of the
    > simplest code.
    >

    Hi,

    I think #1 is OK, however I was under the impression that you
    introduced the exception reverted in #2 due to seeing atomic
    allocation failures?! 

    -- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Nick Piggin: "Re: [patch 3/5] atomic: atomic_inc_not_zero"

    Relevant Pages

    • [patch][rfc] 0/5: remove PageReserved
      ... and clears the way for the page flag to be completely removed ... Arch maintainers and driver writers will need to help get that done. ... Send instant messages to your online friends http://au.messenger.yahoo.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH 01/05] mm fix __alloc_pages cpuset ALLOC_* flags
      ... request that will free up more memory than is asked for (exiting ... With this, cpuset confinement ... flag entirely. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC] cpuset: add interface to isolated cpus
      ... cpuset covering a big chunk of your system, ... could have anything overlapping it. ... just fine by turning off the cpu_exclusive flag. ... Send instant messages to your online friends http://au.messenger.yahoo.com - ...
      (Linux-Kernel)
    • Re: [PATCH]: Clean up of __alloc_pages
      ... > why this lock is needed: ... > * cpuset, and then the cpuset we had could be removed and freed, ... Send instant messages to your online friends http://au.messenger.yahoo.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch 2/2] cpusets: add interleave_over_allowed option
      ... The discussion involving that flag name was kinda mixed up;). ... Christoph has a point when he cautions against breaking this kernel API. ... libnuma software stack. ... from cpuset centric to system centric (if they asked for the ...
      (Linux-Kernel)