Re: [PATCH] hugepages: fold find_or_alloc_pages into huge_no_page()

From: Adam Litke (agl_at_us.ibm.com)
Date: 11/15/05

  • Next message: Jesper Juhl: "Re: [RFC] HOWTO do Linux kernel development - take 2" 
    To: Christoph Lameter <clameter@engr.sgi.com>
Date:	Tue, 15 Nov 2005 16:22:09 -0600

    On Tue, 2005-11-15 at 13:47 -0800, Christoph Lameter wrote:
    > The number of parameters for find_or_alloc_page increases significantly after
    > policy support is added to huge pages. Simplify the code by folding
    > find_or_alloc_huge_page() into hugetlb_no_page().
    >
    > Adam Litke objected to this piece in an earlier patch but I think this is a
    > good simplification. Diffstat shows that we can get rid of almost half of the
    > lines of find_or_alloc_page(). If we can find no consensus then lets simply drop
    > this patch.

    Okay. Since I am the only objector I'll be willing to back down if
    we're sure find_or_alloc_huge_page() has no extra value as a separate
    function. Five parameters is getting a bit unwieldy and suggests it's
    usefulness outside of hugetlb_no_page() is near zero. 

    -- 
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Jesper Juhl: "Re: [RFC] HOWTO do Linux kernel development - take 2"

    Relevant Pages