Re: [PATCH 5/5] slab: fix code formatting

From: Andrew Morton (akpm_at_osdl.org)
Date: 11/19/05

  • Next message: Alan Cox: "Re: [PATCH 2/5] I2O: SPARC fixes"
    Date:	Fri, 18 Nov 2005 18:52:49 -0800
    To: Pekka Enberg <penberg@cs.helsinki.fi>
    
    

    Pekka Enberg <penberg@cs.helsinki.fi> wrote:
    >
    > The slab allocator code is inconsistent in coding style and messy. For this
    > patch, I ran Lindent for mm/slab.c and fixed up goofs by hand.
    >
    > ...
    >
    > slab.c | 1089 ++++++++++++++++++++++++++++++++++-------------------------------
    > 1 file changed, 571 insertions(+), 518 deletions(-)

    Heh. We've been patching slab.c at over one patch per week for six months.
    Chances are I'll drop this one like a hot potato when something else comes
    along. We'll see.

    Yes, one does need to fix up Lindent's leftovers by hand - I'll take a look
    too.

    And yes, slab.c is rather hard on the eyes.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Alan Cox: "Re: [PATCH 2/5] I2O: SPARC fixes"

    Relevant Pages

    • Re: [PATCH] - trivial comment fixups in init/main.c
      ... > This patch has some trivial comment fixups for init/main.c, ... > the comments into consistency with the coding style of the kernel. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC]Add an unlocked_ioctl file operation
      ... > # Add an ioctl path which does not take the BKL. ... about doing lindent patches completely standalone. ... That way we can review each patch on its own merit. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2.6.6-rc3] Lindent on arch/i386/kernel/msr.c
      ... > Per Greg's request this is a patch of having run Lindent on msr.c. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Priority Inheritance Test (Real-Time Preemption)
      ... Is it allowed to send the patch as an attachment instead? ... On Wed, 24 Nov 2004, Ingo Molnar wrote: ... > fixed up the coding style to match that of the kernel's. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: XFS for 2.4
      ... | sure the patch won't break things") ... If Marcelo is not assured of patch reliability, ... don't like the coding style" far easier to believe. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)