Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static

From: Andrew Morton (akpm_at_osdl.org)
Date: 11/24/05

  • Next message: Matthew Garrett: "[PATCH] Add sysfs entry to disable framebuffer access"
    Date:	Wed, 23 Nov 2005 21:05:14 -0800
    To: Dave Jones <davej@redhat.com>
    
    

    Dave Jones <davej@redhat.com> wrote:
    >
    > On Wed, Nov 23, 2005 at 11:54:40PM +0100, Adrian Bunk wrote:
    > > On Wed, Nov 23, 2005 at 02:46:51PM -0800, Randy.Dunlap wrote:
    > > > On Wed, 23 Nov 2005, Adrian Bunk wrote:
    > > >
    > > > > Every inline dummy function should be static.
    > > >
    > > > Please explain why it matters in this case.
    > >
    > > We don't need an additional global copy of the function.
    >
    > it's an empty body, surely the compiler will compile it away ?
    >

    With

    inline void foo(void)
    {
    }

    The compiler has to put an out-of-line copy of foo() into this .o file in
    case some other .o file calls it.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Matthew Garrett: "[PATCH] Add sysfs entry to disable framebuffer access"

    Relevant Pages

    • Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
      ... > it's an empty body, surely the compiler will compile it away? ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
      ... it's an empty body, surely the compiler will compile it away? ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [discuss] booting a kernel compiled with -mregparm=0
      ... > this one) and even if GCC produced valid code by miracle, ... That's the default for a 'C' compiler (not to pass parameters ... This forced some parameters to be passed in registers, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: PATCH, RFC: 2.6 Documentation/Codingstyle
      ... Giuliano Pochini wrote: ... A compiler should do it, a maintainer IMHO should not for a really simple ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: ALSA vs. OSS
      ... Loading the kernel version of the modules always fails with: ... perhaps from the compiler, which I compiled myself: ... gcc 2.95.3) and binutils 2.14. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)