Re: [patch] drivers/scsi/dpt_i2o.c: fix a NULL pointer dereference

From: Adrian Bunk (bunk_at_stusta.de)
Date: 11/27/05

  • Next message: Bernhard Rosenkraenzer: "2.6.15-rc2-mm1: kernel BUG at kernel/timer.c:213" 
    Date:	Sun, 27 Nov 2005 19:52:52 +0100
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>

    On Sun, Nov 27, 2005 at 10:47:38AM -0200, Marcelo Tosatti wrote:
    > On Sun, Nov 27, 2005 at 12:36:37AM +0100, Adrian Bunk wrote:
    > > The Coverity checker spotted this obvious NULL pointer dereference.
    >
    > Hi Adrian,

    Hi Marcelo,

    > Could you explain why you remove the adpt_post_wait_lock acquision?
    >
    > And if it does not belong there, why don't you remove it instead of
    > commeting out?
    >...

    my patch does remove the following not required line:

    > > - p2 = NULL;

    It does not touch the following line that was already commented out:

    > > // spin_lock_irqsave(&adpt_post_wait_lock, flags);
    >...

    cu
    Adrian 

    -- 
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Bernhard Rosenkraenzer: "2.6.15-rc2-mm1: kernel BUG at kernel/timer.c:213"

    Relevant Pages

    • Re: [2.6 patch] schedule obsolete OSS drivers for removal (version 2)
      ... > that's where they belong anyway. ... I'd deprecate them without moving them. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] drivers/pnp/: possible cleanups
      ... modular code will use any of them, ... Modular ISAPnP might be interesting in some cases, ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: A users thoughts on the new dev. model
      ... >> when the stable tree wasn't. ... Andrew said explicitely in a mail to linux-kernel that he'd consider ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] let W1 select NET
      ... > selecting the required dependencies. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] drivers/acpi: remove unused exported functions
      ... > future patches, but sometimes Real Life gets in the way and the ... > programmer stalls development for some time, no problem, just ifdef it. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)