Re: [PATCH] hpfs: Whitespace and Codingstyle cleanup for dir.c

From: Jesper Juhl (jesper.juhl_at_gmail.com)
Date: 11/29/05

  • Next message: Eric Dumazet: "[PATCH] shrinks dentry struct" 
    Date:	Tue, 29 Nov 2005 16:17:49 +0100
To: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>

    On 10/12/05, Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> wrote:
    >
    >
    > On Wed, 12 Oct 2005, Jesper Juhl wrote:
    >
    > > Whitespace and CodingStyle cleanup for fs/hpfs/dir.c
    > >
    > > While reading through fs/hpfs/dir.c I ran across lots of cases of multiple
    > > statements on a single line that made some bits of the file quite confusing
    > > to read. This patch cleans that up and also make sure labels are placed at
    > > column 1, removes trailing whitespace and a few other minor CodingStyle nits.
    >
    > I don't see anything wrong with
    > if (some_condition) do_some_action();
    > statements. Generally, if they consume less lines, you can see more code
    > on a screen.
    >
    > Mikulas
    >

    Well, as Pekka Enberg also pointed out, Documentation/CodingStyle says
    that's not the prefered way. But, it's your code, so if you don't like
    the cleanups don't apply them.
    i still think the patch is a good idea and makes the file more readable though.

    > > There are some very long lines in this file that would be a lot more readable
    > > (IMHO) if broken up to fit within 80 cols. This patch does not do that, but
    > > if wanted I can submit an aditional patch on top of this one to do that.
    > >
    Same with this bit, IMHO a good idea, but I won't bother making a
    patch if you don't want it. 

    --
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Eric Dumazet: "[PATCH] shrinks dentry struct"

    Relevant Pages