[PATCH] setting irq affinity is broken in ia32 with MSI enabled

From: Shaohua Li (shaohua.li_at_intel.com)
Date: 11/30/05

  • Next message: Jon Masters: "Re: floppy regression from "[PATCH] fix floppy.c to store correct ..."" 
    To: lkml <linux-kernel@vger.kernel.org>
Date:	Wed, 30 Nov 2005 00:37:15 -0800

    Setting irq affinity stops working when MSI is enabled. With MSI,
    move_irq is empty, so we can't change irq affinity. It appears a typo in
    Ashok's original commit for this issue. X86_64 actually is using
    move_native_irq.

    Signed-off-by: Shaohua Li <shaohua.li@intel.com>

    --- a/arch/i386/kernel/io_apic.c 2005-11-29 22:22:16.000000000 -0800
    +++ b/arch/i386/kernel/io_apic.c 2005-11-29 22:23:01.000000000 -0800
    @@ -2009,7 +2009,7 @@ static void ack_edge_ioapic_vector(unsig
     {
             int irq = vector_to_irq(vector);
     
    - move_irq(vector);
    + move_native_irq(vector);
             ack_edge_ioapic_irq(irq);
     }
     
    @@ -2024,7 +2024,7 @@ static void end_level_ioapic_vector (uns
     {
             int irq = vector_to_irq(vector);
     
    - move_irq(vector);
    + move_native_irq(vector);
             end_level_ioapic_irq(irq);
     }
     

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Jon Masters: "Re: floppy regression from "[PATCH] fix floppy.c to store correct ...""

    Relevant Pages