Re: [PATCH] shrinks dentry struct

From: Andrew Morton (akpm_at_osdl.org)
Date: 11/30/05

  • Next message: Paul Walmsley: "[PATCH] Force starget->scsi_level in usb-storage scsiglue.c" 
    Date:	Tue, 29 Nov 2005 18:14:21 -0800
To: Paul Jackson <pj@sgi.com>

    Paul Jackson <pj@sgi.com> wrote:
    >
    > Would the following accomplish the same thing as your patch, to shrink
    > UP dentry structs back to 128 bytes, with a smaller and less intrusive
    > patch?
    >
    > ...
    > - struct list_head d_child; /* child of parent list */
    > + union { /* Fit 32 bit UP dentry in 128 bytes */
    > + struct list_head du_child; /* child of parent list */
    > + struct rcu_head du_rcu;
    > + } d_du;
    > ...
    >
    > +#define d_child d_du.du_child
    > +#define d_rcu d_du.du_rcu

    Yes, but it's better to just do the big edit, rather than letting these
    little namespace crufties accumulate over time.

    Even better would be to ditch gcc-2.95.x and use an anonymous union, but
    Hugh won't let me ;)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Paul Walmsley: "[PATCH] Force starget->scsi_level in usb-storage scsiglue.c"