[PATCH 3/4] stack overflow safe kdump ( 2.6.15-rc3-i386) - do_nmi

From: Fernando Luis Vazquez Cao (fernando_at_intellilink.co.jp)
Date: 11/30/05

  • Next message: Arjan van de Ven: "Re: [PATCH 0/9] x86-64 put current in r10"
    To: "Eric W. Biederman" <ebiederm@xmission.com>
    Date:	Wed, 30 Nov 2005 16:36:57 +0900
    
    

    crash_nmi_callback is called right after a system crash which might have
    caused by stack overflow, thus smp_processor_id should not be trusted.
    Use the safe replacement safe_smp_processor_id.

    ---
    diff -urNp linux-2.6.15-rc3/arch/i386/kernel/traps.c linux-2.6.15-rc3-sov/arch/i386/kernel/traps.c
    --- linux-2.6.15-rc3/arch/i386/kernel/traps.c	2005-11-30 14:51:49.000000000 +0900
    +++ linux-2.6.15-rc3-sov/arch/i386/kernel/traps.c	2005-11-30 14:55:57.000000000 +0900
    @@ -648,7 +648,7 @@ fastcall void do_nmi(struct pt_regs * re
     
     	nmi_enter();
     
    -	cpu = smp_processor_id();
    +	cpu = safe_smp_processor_id();
     
     #ifdef CONFIG_HOTPLUG_CPU
     	if (!cpu_online(cpu)) {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Arjan van de Ven: "Re: [PATCH 0/9] x86-64 put current in r10"

    Relevant Pages

    • [PATCH 3/4] stack overflow safe kdump (i386) - do_nmi
      ... crash_nmi_callback is called right after a system crash which might have ... caused by stack overflow, thus smp_processor_id should not be trusted. ... Use the safe replacement safe_smp_processor_id. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • problems w/ 2.6.9-rc2
      ... System crash (sysrq not working) when i try record tv. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Realtime Preemption, 2.6.12, Beginners Guide?
      ... and clearly a sideaffect of 4KSTACKS.. ... > actually being a stack overflow. ... > I realise 4KSTACKS is a considerable rework of the IRQ handler, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Realtime Preemption, 2.6.12, Beginners Guide?
      ... On Monday 11 Jul 2005 15:16, Ingo Molnar wrote: ... > i cannot see anything wrong in it, but your esp is 0xc04cded0, ... Actually, it's now pretty much confirmed that this ISN'T a stack overflow, not ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: How to find out kernel stack over flow?
      ... >>the kernel may be causing the stack overflow which is ... Nominally a stack overflow results in the corruption of data at the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)