Re: [PATCH linux-2.6-block:post-2.6.15 09/11] blk: implement ide_driver_t->protocol_changed callback

From: Bartlomiej Zolnierkiewicz (bzolnier_at_gmail.com)
Date: 11/30/05

  • Next message: Bartlomiej Zolnierkiewicz: "Re: [PATCH linux-2.6-block:post-2.6.15 08/11] blk: update IDE to use new blk_ordered" 
    Date:	Wed, 30 Nov 2005 11:58:51 +0100
To: Tejun Heo <htejun@gmail.com>

    On 11/24/05, Tejun Heo <htejun@gmail.com> wrote:
    > 09_blk_ide-add-protocol_changed.patch
    >
    > This patch implements protocol_changed callback for IDE HL
    > drivers. The callback is called whenever transfer protocol
    > changes (DMA / multisector PIO / PIO). The callback is
    > sometimes with context and sometimes without, sometimes with
    > queuelock, sometimes not. So, actual callbacks should be
    > written carefully.
    >
    > To hook dma setting changes, this function implements
    > ide_dma_on() and ide_dma_off_quietly() which notifies protocl
    > change and calls low level driver callback. __ide_dma_off()
    > is renamed to ide_dma_off() for consistency. All dma on/off
    > operations must be done by using these wrapper functions.
    >
    > Signed-off-by: Tejun Heo <htejun@gmail.com>

    NACK

    Please fix the real problem instead
    (changing of DMA and multicount PIO settings is racy).

    Bartlomiej
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Bartlomiej Zolnierkiewicz: "Re: [PATCH linux-2.6-block:post-2.6.15 08/11] blk: update IDE to use new blk_ordered"

    Relevant Pages