Re: [PATCH 1/9] timer locking optimization

From: Roman Zippel (zippel_at_linux-m68k.org)
Date: 11/30/05

  • Next message: downtune: "Sell your music directly to your fans" 
    Date:	Wed, 30 Nov 2005 12:06:17 +0100 (CET)
To: Oleg Nesterov <oleg@tv-sign.ru>

    Hi,

    On Wed, 30 Nov 2005, Oleg Nesterov wrote:

    > Another problem. __mode_timer() does:
    >
    > if (timer_pending(timer)) {
    > detach_timer(timer, 0);
    >
    > Note that 'clear_pending' parameter == 0. This means that detach_timer()
    > will remove the timer from list, but won't clear 'pending' status. So
    > this will crash after 'goto restart' (or in case of concurrent del_timer()).

    I just noticed this too. I'll drop the patch and I'll also change the
    second patch.
    Thanks for looking into this.

    bye, Roman
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: downtune: "Sell your music directly to your fans"

    Relevant Pages