Re: [PATCH][mm] swsusp: limit image size

Rafael J. Wysocki wrote:
> On Friday, 9 December 2005 16:48, Stefan Seyfried wrote:
>
>> What happens if IMAGE_SIZE is bigger than free swap? Do we "try harder"
>> or do we fail?
>
> First, with swsusp the image can't be bigger than 1/2 of lowmem (1/2 of RAM
> on x86-64) and the too great values of IMAGE_SIZE have no effect. Still, if
> the amount of free swap is smaller than 1/2 of RAM and the image happens
> to be bigger, we will fail.

ok. This is not nice since we might fail without any _real_ need. Can we
make this parameter userspace-tweakable, so that my userspace app can do
something like (pseudocode):

echo 500 > /sys/power/swsusp/imagesize
echo disk > /sys/power/state
R=$?
if [ $R -eq $ENOMEM ]; then
echo 100 > /sys/power/swsusp/imagesize # try again
echo disk > /sys/power/state
R=$?
fi
if [ $R -ne 0 ]; then
pop_up_some_loud_beeping_window "suspend failed!"
fi

This would at least give us a chance for a second try. I know that Pavel
dislikes userspace tunables, but i dislike failing suspends ;-)

Best regards,

Stefan
--
Stefan Seyfried \ "I didn't want to write for pay. I
QA / R&D Team Mobile Devices \ wanted to be paid for what I write."
SUSE LINUX Products GmbH, Nürnberg \ -- Leonard Cohen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH][mm] swsusp: limit image size
    ... >> swsusp to take this constant into account (500 is the default value ... with swsusp the image can't be bigger than 1/2 of lowmem (1/2 of RAM ... to be bigger, we will fail. ...
    (Linux-Kernel)
  • Re: [PATCH 1/3][BUGFIX] configfs: Introduce configfs_dirent_lock
    ... Between detach_prepin A and mkdir() in a default group A/B: ... but attach_groupmay then fail (because of memory ... userspace: either userspace sees a group with all of its default groups, ... Again this is the concern of atomicity from userspace point of view: ...
    (Linux-Kernel)
  • Re: PC problems
    ... I have had cases where a RAM may fail the diagnostics in one machine, ... If you get a bad indication of the RAM, it is best to replace it, and not ... Strangely the dodgy DIMM works ...
    (sci.electronics.repair)
  • Re: how necessary is a windlass
    ... mechanical and electrical things fail all the time, ... I know some pretty tough people in their 60's and 70's. ... This bigger is better attitude is just plain stupid. ... The SUV bunch is bad enough but what about the greedy people driving RV's? ...
    (rec.boats.cruising)
  • Re: Im At My Wits End!!!!!!!!!!!!!!!!!!!!!!!!!
    ... settings, a disk drive or RAM beginning to fail, or some other very logical explanation which we fail to recognize. ... infancy of the NLE software with twenty exclamation point exasperated posts to a newsgroup is the last step, not the first, as I ...
    (rec.video.production)