Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
- From: Matthew Wilcox <matthew@xxxxxx>
- Date: Wed, 14 Dec 2005 09:24:37 -0700
On Wed, Dec 14, 2005 at 05:14:30PM +0100, Martin Peschke wrote:
> if (device_register(&unit->sysfs_device)) {
> + zfcp_unit_statistic_unregister(unit);
> kfree(unit);
> return NULL;
> }
>
> if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) {
> + zfcp_unit_statistic_unregister(unit);
> device_unregister(&unit->sysfs_device);
> return NULL;
> }
Unrelated, but doesn't that error path forget to release unit?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
- From: Martin Peschke
- Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
- References:
- [patch 6/6] statistics infrastructure - exploitation: zfcp
- From: Martin Peschke
- [patch 6/6] statistics infrastructure - exploitation: zfcp
- Prev by Date: Re: [RFC][PATCH 3/6] Slab Prep: get/return_object
- Next by Date: Re: [RFC][PATCH 1/6] Create Critical Page Pool
- Previous by thread: [patch 6/6] statistics infrastructure - exploitation: zfcp
- Next by thread: Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
- Index(es):
Relevant Pages
|
