Re: [patch 04/15] Generic Mutex Subsystem, add-atomic-call-func-x86_64.patch

On Tue, Dec 20, 2005 at 11:35:22AM -0500, Nicolas Pitre wrote:
> So 14 instructions total with preemption disabling, and that's with the
> best implementation possible by open coding everything instead of
> relying on generic functions/macros.

I agree with your analysis Nicolas.

However, don't forget to compare this with our existing semaphore
implementation which is 9 instructions, or 8 for the SMP version.

In total, this means that mutexes will be _FAR MORE EXPENSIVE_ on ARM
than our semaphores.

Forcing architectures down the "lets make everything generic" path
does not always hack it. It can't do by its very nature. Generic
implementations are *always* sub-optimal and it is pretty clear
that any gain that mutexes _may_ give is completely wasted on ARM
by the overhead of having a generic framework imposed upon us.

So, to sum up, if this path is persued, mutexes will be a bloody
disaster on ARM. We'd be far better off sticking to semaphores
and ignoring this mutex stuff.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [patch 0/9] mutex subsystem, -V4
    ... > work into improving semaphores as you have into developing mutexes. ... semaphore semantics _require_ atomic increments/decrements where mutexes ... This makes a huge difference on ARM where 99% of all ARM ...
    (Linux-Kernel)
  • Re: [patch 0/9] mutex subsystem, -V4
    ... > this thing about optimizing for the common case? ... Semaphores are not that different from mutexes. ... but if we compare them to semaphores it should be a fair ...
    (Linux-Kernel)
  • [PATCH] kernel/cpuset.c mutex conversion comment fix
    ... The conversion of kernel/cpuset from semaphores to mutexes ... I didn't know offhand the state of read-write mutexes, ... - * We have two global cpuset semaphores below. ... - * zero, then only attach_task, which holds both semaphores, can ...
    (Linux-Kernel)
  • Re: [patch 2/3] mutex subsystem: fastpath inlining
    ... >> Some architectures, notably ARM for instance, might benefit from ... So our starting point for comparison is 9 instructions for every down ... downand every upsimply going with mutexes. ... cycles since a function prologue and epilogue is somewhat costly on ARM, ...
    (Linux-Kernel)
  • Re: help w/ mutex
    ... Mutexes are not any faster than semaphores, as they both involve switch to ... > thread-dependant, they are merely count down dependant. ... a CriticalSection is probably what you ...
    (microsoft.public.win32.programmer.kernel)