Re: [patch 00/2] improve .text size on gcc 4.0 and newer compilers


* Adrian Bunk <bunk@xxxxxxxxx> wrote:

> > unit-at-a-time still increases the kernel stack footprint somewhat (by
> > about 5% in the CC_OPTIMIZE_FOR_SIZE case), but not by the insane degree
> > gcc3 used to, which prompted the original -fno-unit-at-a-time addition.
> >...
>
> Please hold off this patch.
>
> I do already plan to look at this after the smoke has cleared after
> the 4k stacks issue. I want to avoid two different knobs both with
> negative effects on stack usage (currently CONFIG_4KSTACKS=y, and
> after your patch gcc >= 4.0) giving a low testing coverage of the
> worst cases.

this is obviously not 2.6.15 stuff, so we've got enough time to see the
effects. [ And what does "I do plan to look at this" mean? When
precisely, and can i thus go to other topics without the issue being
dropped on the floor indefinitely? ]

also note that the inlining patch actually _reduces_ average stack
footprint by ~3-4%:
orig +inlining
# of functions above 256 bytes: 683 660
total stackspace, bytes: 148492 142884

it is the unit-at-a-time patch that increases stack footprint (by about
7-8%, which together with the inlining patch gives a net ~5%).

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Wine and mmap
    ... Apply the attached patch for vm_mmap to ... > compile and install wine. ... This seems to just work around a side effect of the kernel mmap patch. ... * top of the main stack. ...
    (freebsd-current)
  • Re: RFC: TSO patch for current
    ... > This is a patch for the stack and the em driver to enable TSO ...
    (freebsd-current)
  • Re: RFC: TSO patch for current
    ... > This is a patch for the stack and the em driver to enable TSO ...
    (freebsd-net)
  • Re: [PATCH] m68knommu: add pretty back strace
    ... The backtrace shows resolved function names and their numeric ... This is really not my area, but this patch reminds me of all the dwarf2 unwinder on x86 that caused so many problems in the beginning... ... The old method printed every value from stack which was in the text ... find a pattern without frame pointers but I had no luck. ...
    (Linux-Kernel)
  • Re: [patch 00/2] improve .text size on gcc 4.0 and newer compilers
    ... >> Please hold off this patch. ... "I do plan to look at this" means that I'd currently estimate this being ... > also note that the inlining patch actually _reduces_ average stack ... The problem with the stack is that average stack usage is relatively ...
    (Linux-Kernel)