Re: [PATCH] protect remove_proc_entry

From: Daniel Walker <dwalker@xxxxxxxxxx>
Date: Fri, 30 Dec 2005 13:34:26 -0800

On Fri, 2005-12-30 at 16:28 -0500, Steven Rostedt wrote:

> + spin_lock_irqsave(&remove_proc_lock, flags);
...
> + spin_unlock_irqrestore(&remove_proc_lock, flags);

Why do an irqsave here? Are you not sure what context it gets called
from?

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] protect remove_proc_entry
  - From: Steven Rostedt

References:
- [Question] race condition with remove_proc_entry
  - From: Steven Rostedt
- [PATCH] protect remove_proc_entry
  - From: Steven Rostedt

Prev by Date: Re: system keeps freezing once every 24 hours / random apps crashing
Next by Date: Re: system keeps freezing once every 24 hours / random apps crashing
Previous by thread: [PATCH] protect remove_proc_entry
Next by thread: Re: [PATCH] protect remove_proc_entry
Index(es):
- Date
- Thread

Relevant Pages

Re: [2.6 patch] blackfin: remove dump_thread()
... # line filename / context / line ... More majordomo info at http://vger.kernel.org/majordomo-info.html
... Please read the FAQ at http://www.tux.org/lkml/ ... (Linux-Kernel)
Re: [RFC][PATCH 2/6] sysvmsg: containerize
... Does that mean /proc interface only gets init_task context? ... It will get
context from the current task, ... to sysadmin mandated resource limits, it's effectively
a leak, esp. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
(Linux-Kernel)
Re: [PATCH] protect remove_proc_entry
... On Fri, 30 Dec 2005, Daniel Walker wrote: ... [snipped from original message]
... "I'm not sure if remove_proc_entry is called from interrupt context, ... did
a irqsave just in case." ... (Linux-Kernel)
Re: Robbie Gordon? Suspended?
... or if he was just parroting the term in the same context ... > ummm...
... your're the one looking completely moronic here, dumbass... ... but Daniel
has done plenty in this group to make himself look ... (rec.autos.sport.nascar)
Re: [BUG on PREEMPT_RT, 2.6.23.1-rt5] in rt-mutex code and signals
... Hey Ingo and Daniel, Leave some of the fun open for me :-) ... More majordomo
info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/
... (Linux-Kernel)