Re: [PATCH] protect remove_proc_entry

From: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Date: Fri, 30 Dec 2005 13:55:44 -0800

Steven Rostedt wrote:
> I've added a global remove_proc_lock to protect this section of code. I
> was going to add a lock to proc_dir_entry so that the locking is only
> cut down to the same parent, but since this function is called so
> infrequently, why waste more memory then is needed. One global lock
> should not cause too much of a headache here.

Are you sure that it's the only place where we need guard ->subdir? It
looks like proc_lookup() and proc_readdir() use the BLK when walking that
list, so probably the best fix would be to use that lock everywhere else
->subdir is touched

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] protect remove_proc_entry
  - From: Steven Rostedt
- Re: [PATCH] protect remove_proc_entry
  - From: Steven Rostedt

References:
- [Question] race condition with remove_proc_entry
  - From: Steven Rostedt
- [PATCH] protect remove_proc_entry
  - From: Steven Rostedt

Prev by Date: Re: system keeps freezing once every 24 hours / random apps crashing
Next by Date: Re: [PATCH] protect remove_proc_entry
Previous by thread: Re: [PATCH] protect remove_proc_entry
Next by thread: Re: [PATCH] protect remove_proc_entry
Index(es):
- Date
- Thread

Relevant Pages

Re: lock used in thread and by event
... First class has a method which use lockand then it put itself ... public
Parent() ... lock ... public void CalledByEvent() ... (microsoft.public.dotnet.languages.csharp)
Re: device struct bloat
... Just locking the tree root is not enough? ... modifying operation to descend
into the tree). ... I'd first start by asking if you want to lock all the children
or the ... parent again. ... (Linux-Kernel)
Re: Lock MSSQL Table Row?
... I am using OleDb to connect to MSSQL. ... reads the parent table and
2 child tables into a DataSet. ... When a save happens, I want to lock the parent row,
compare the "lock" ... Use the existing OleDbConnection with new OleDbCommands to do ...
(microsoft.public.dotnet.framework.adonet)
Re: Race condition in debugger?
... What happens is that the debugger hangs at some ... that there's no lock
protecting that the conditions in the ... >hold the parent lock across the bulk
of kern_wait, ... the race has just occurred. ... (freebsd-current)
Re: device struct bloat
... acquires the semaphores for _all_ the devices in the tree. ... any time a driver's
probe routine tries to register a child ... lock in order to probe drivers for the
child. ... (it having a locked child, your parent, should be ... (Linux-Kernel)