Re: [PATCH] protect remove_proc_entry

From: Steven Rostedt <rostedt@xxxxxxxxxxx>
Date: Fri, 30 Dec 2005 16:55:49 -0500 (EST)

On Fri, 30 Dec 2005, Daniel Walker wrote:

> On Fri, 2005-12-30 at 16:28 -0500, Steven Rostedt wrote:
>
> > + spin_lock_irqsave(&remove_proc_lock, flags);
> ...
> > + spin_unlock_irqrestore(&remove_proc_lock, flags);
>
> Why do an irqsave here? Are you not sure what context it gets called
> from?
>

[snipped from original message]
"I'm not sure if remove_proc_entry is called from interrupt context, so I
did a irqsave just in case."

;-)

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

References:
- [Question] race condition with remove_proc_entry
  - From: Steven Rostedt
- [PATCH] protect remove_proc_entry
  - From: Steven Rostedt
- Re: [PATCH] protect remove_proc_entry
  - From: Daniel Walker

Prev by Date: Re: [PATCH] protect remove_proc_entry
Next by Date: Re: system keeps freezing once every 24 hours / random apps crashing
Previous by thread: Re: [PATCH] protect remove_proc_entry
Next by thread: Re: [PATCH] protect remove_proc_entry
Index(es):
- Date
- Thread

Relevant Pages

Re: Mail etiquette (was: What is this mean by this term)
... different people configure and use their email clients in different ... message
as soon as it arrives. ... There it is often the case that people do not have the original
message ... to get the context from. ... (freebsd-questions)
Re: char array not terminated with
... I've snipped the original message, ... > enough context. ...
For completeness: ... by the compiler, as happens when no size is explicitly specified:
... (comp.lang.c)
Re: how to change sys.path?
... [Please provide some context when you respond in an existing ... by quoting
the original message and removing any parts ... (comp.lang.python)
Re: Installing GCC...
... On Sat, 4 Feb 2006, Randal T. Rioux wrote: ... original message remains
for context. ... What's the most annoying thing on Usenet and in email? ...
(comp.unix.solaris)
Re: [PATCH] protect remove_proc_entry
... Why do an irqsave here? ... Are you not sure what context it gets called
... Daniel ... More majordomo info at http://vger.kernel.org/majordomo-info.html
... (Linux-Kernel)