Re: [PATCH] Fix user data corrupted by old value return of sysctl
- From: Coywolf Qi Hunt <coywolf@xxxxxxxxx>
- Date: Sat, 31 Dec 2005 17:44:06 +0800
2005/12/31, Yi Yang <yang.y.yi@xxxxxxxxx>:
> Coywolf Qi Hunt wrote:
> >You didn't set the trailing '\0', I wonder how your printf did work
> >properly ever. You've just been lucky or something.
> >
> >-- Coywolf
> >
> >
> The variable target does it, its value is 0x00000001, so you mustn't
> worry it.
> osname only has 4-bytes space, so if you set '\0' to its tail, a byte
> information will be lost.
I'm worrying more. We should set '\0'. Let the one byte information
lost, the caller deserve that. Actually here printf sees "mylo"+'\01'
if little endian.
Linus, besides fixing bug, your commit certainly breaks userland
compatibility. Please consider.
--
Coywolf Qi Hunt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH] Fix user data corrupted by old value return of sysctl
- From: Yi Yang
- Re: [PATCH] Fix user data corrupted by old value return of sysctl
- From: Coywolf Qi Hunt
- Re: [PATCH] Fix user data corrupted by old value return of sysctl
- From: Yi Yang
- [PATCH] Fix user data corrupted by old value return of sysctl
- Prev by Date: Re: [PATCH 14/14] page-replace-kswapd-incmin.patch
- Next by Date: Re: [PATCH 01/14] page-replace-single-batch-insert.patch
- Previous by thread: Re: [PATCH] Fix user data corrupted by old value return of sysctl
- Next by thread: Latterly created funky mixture of sch0o1girls encoded
- Index(es):
Relevant Pages
|
|
