Re: RFC: add udev support to parport_pc

Jason Dravet napsal(a):
> Here is a patch to parport_pc.c that adds udev support. Without it
> sysfs does not have enough information to give to udev so the lp and
> parport nodes can be created. The only problem I have is the
> kernel_oops when I do the following: insmod parport, insmod parport_pc,
> rmmod parport_pc, rmmod parport, insmod parport, insmod parport_pc,
> rmmod parport_pc, kernel oops.
[snip]
> + if (p->base == 888) /* 888 is dec for 378h */
> + {
> + class_device_create(parallel_class, NULL, MKDEV(6, 0), NULL,
> "lp0");
> + class_device_create(parallel_class, NULL, MKDEV(99, 0), NULL,
> "parport0");
> + }
use please
if () {
}
instead of
if ()
{
}
like the surrounding code

thanks,
--
Jiri Slaby www.fi.muni.cz/~xslaby
\_.-^-._ jirislaby@xxxxxxxxx _.-^-._/
B67499670407CE62ACC8 22A032CC55C339D47A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: RFC: add udev support to parport_pc
    ... > Here is a patch to parport_pc.c that adds udev support. ... The only problem I have is the> kernel_oops when I do the following: insmod parport, insmod parport_pc, ... > rmmod parport_pc, rmmod parport, insmod parport, insmod parport_pc, ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • RFC: add udev support to parport_pc
    ... Here is a patch to parport_pc.c that adds udev support. ... Without it sysfs does not have enough information to give to udev so the lp and parport nodes can be created. ... The only problem I have is the kernel_oops when I do the following: insmod parport, insmod parport_pc, rmmod parport_pc, rmmod parport, insmod parport, insmod parport_pc, rmmod parport_pc, kernel oops. ...
    (Linux-Kernel)
  • Re: [Bug 34473] hwinfo hangs on rmmod
    ... >> the core module locking other kernel modules can show the same problem. ... >> if we should take the risk of having other modules hanging in rmmod and fix only ... >> parport, or if we should apply this fix which fixes all the modules at the same ...
    (Linux-Kernel)
  • Re: [SLE] insmod-- newbie
    ... I did need to rmmod in the correct order. ... path to parport and parport_pc ... modprobe /path/to/parport/parport_pc ...
    (SuSE)
  • Re: [Linux-parport] [RFC]: add sysfs support to parport_pc, v3
    ... I fixed my earilier problem of the kernel oops (I forgot the ... > class_destory) and I can insmod and rmmod this module all day long with no ... I do have one question why do both lp and parport nodes have ...
    (Linux-Kernel)