Re: [PATCH]-jsm driver fix for linux-2.6.16-rc1



On Fri, Jan 20, 2006 at 10:02:38AM -0600, V. Ananda Krishnan wrote:
> @@ -20,8 +20,11 @@
> *
> * Contact Information:
> * Scott H Kilau <Scott_Kilau@xxxxxxxx>
> - * Wendy Xiong <wendyx@xxxxxxxxxxxxxxxxxxxxxxx>
> - *
> + * Wendy Xiong <wendyx>

That's not an email address, why not just fix Wendy's to be correct, or
drop it if that's not the person to contact?

> + /*
> + * If the DONT_FLIP flag is on, don't flush our buffer, and act

Wrong code indentation, use tabs please. This is in a number of places
in the patch.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [PATCH 2/3] s390: Replace driver_data with dev_[gs]et_drvdata
    ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... Prev by Date: ...
    (Linux-Kernel)
  • Re: [PATCH] sched: Fix __load_balance_iterator() for cfq with only one task
    ... Fix this by checking if the last entity was a task or not. ... pairs not running on the same CPU as buddies, shouldn't this be fixed in a ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [patch] latency tracer, 2.6.15-rc7
    ... Lee ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... Prev by Date: ...
    (Linux-Kernel)
  • Re: 2.6.18-rt1
    ... the fix. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... Copyright 2006 by Maurice Eugene Heskett, ...
    (Linux-Kernel)
  • Re: [PATCH] sched: Fix __load_balance_iterator() for cfq with only one task
    ... It is caused by the following code-path. ... Fix this by checking if the last entity was a task or not. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)