Re: [PATCH] sungem: Make PM of PHYs more reliable



On Sun, 2006-01-22 at 13:59 +1100, Benjamin Herrenschmidt wrote:
> On my latest laptop, I've had occasional PHY dead on wakeup from
> sleep... the PHY would be totally unresponsive even to toggling the hard
> reset line until the machine is powered down... Looking closely at the
> code, I found some possible issues in the way we setup the MDIO lines
> during suspend along with slight divergences from what Darwin does when
> resetting it that may explain the problem. That patch change these and
> the problem appear to be gone for me at least... I also fixed an mdelay
> -> msleep while I was at it to the pmac feature code that is called
> when toggling the PHY reset line since sungem doesn't call it in an
> atomic context anymore.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> ---

Oops, -EWRONGPATCH... Sorry, please ignore it, I'll dig the right one...

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [PATCH] sungem: Make PM of PHYs more reliable (#2)
    ... I've had occasional PHY dead on wakeup from ... the PHY would be totally unresponsive even to toggling the hard ... reset line until the machine is powered down... ... static void gem_stop_phy(struct gem *gp, ...
    (Linux-Kernel)
  • [PATCH] sungem: Make PM of PHYs more reliable
    ... I've had occasional PHY dead on wakeup from ... the PHY would be totally unresponsive even to toggling the hard ... reset line until the machine is powered down... ... -> msleep while I was at it to the pmac feature code that is called ...
    (Linux-Kernel)
  • Re: [PATCH] sungem: Make PM of PHYs more reliable (#2)
    ... I've had occasional PHY dead on wakeup from ... the PHY would be totally unresponsive even to toggling the hard ... > -> msleep while I was at it to the pmac feature code that is called ... > when toggling the PHY reset line since sungem doesn't call it in an ...
    (Linux-Kernel)
  • Re: [PATCH 1/1] IBM PPC EMAC driver:improved support for PHY configuration
    ... driver for PPC32 systems. ... followed by a read/modify/write of the control register. ... what I found is that on at least one PHY model ... the read of the control register comes back with the soft reset bit set ...
    (Linux-Kernel)
  • [PATCH 1/1] IBM PPC EMAC driver:improved support for PHY, resending
    ... this was harder than fixing the driver). ... followed by a read/modify/write of the control register. ... what I found is that on at least one PHY model ... the read of the control register comes back with the soft reset bit set ...
    (Linux-Kernel)