[PATCH] Fix compile error in latest git pull - post 2.6.16-rc1-git4



After doing a git pull from linux/kernel/git/torvalds/linux-2.6.git, I get the following compiler error:

  CC      net/ipv4/igmp.o
net/ipv4/igmp.c: In function ‘igmp_rcv’:
net/ipv4/igmp.c:973: error: label at end of compound statement

Using git bisect, the patch that introduces this error is:

 c5d90e000437a463440c1fe039011a02583a9ee5 is first bad commit
diff-tree c5d90e000437a463440c1fe039011a02583a9ee5 (from e2c2fc2c8f3750e1f7ffbb3ac2b885a49416110c)
Author: Dave Jones <davej@xxxxxxxxxx>
Date:   Mon Jan 30 20:27:17 2006 -0800

    [IPV4] igmp: remove pointless printk

    This is easily triggerable by sending bogus packets,
    allowing a malicious user to flood remote logs.

    Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>


I suspect this error arises due to differences between gcc 4.0.2 and earlier releases. The patch is as follows:


diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index f70ba62..0b4e95f 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -970,6 +970,7 @@ int igmp_rcv(struct sk_buff *skb)
        case IGMP_MTRACE_RESP:
                break;
        default:
+               break;
        }

 drop:


Larry Finger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: 1352 NUL bytes at the end of a page?
    ... I don't think anyone has cleared up the performance regression ... because I suspect it could be something ... specific to the SuSE kernel rather than a regression in Linus' tree ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: 2.6.2-rc2 nfsd+xfs spins in i_size_read()
    ... this call should not actually be updating the size. ... >>Would be a good starting point, I suspect those calls from the nfs ... >>revalidate call are not really going to change the inode size. ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: UTF-8 and case-insensitivity
    ... without restarting the whole lookup. ... > EFOAD, it can do ... > I suspect most people don't care that much, ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [patch] voluntary-preempt-2.6.8-rc3-O4
    ... > ALSA-detected xruns as well? ... I do not seem to get false positives anymore, IOW, all the traces I send ... I suspect that with a lower ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [patch] kernel events layer
    ... Predicting the future is hard, but I suspect this number to be small. ... The race is definitely not worth fixing. ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)