Re: [PATCH 2/11] LED: Add LED Class

On Tue, Jan 31, 2006 at 01:41:28PM +0000, Richard Purdie wrote:
> +/**
> + * led_device_register - register a new object of led_device class.
> + * @dev: The device to register.
> + * @led_dev: the led_device structure for this device.
> + */
> +int led_device_register(struct device *dev, struct led_device *led_dev)

Shouldn't struct led_device contain a struct device within it, like the
rest of the driver model?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 2/11] LED: Add LED Class
    ... >> rest of the driver model? ... > The code supports more than one led per struct device. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [PATCH 2/11] LED: Add LED Class
    ... > rest of the driver model? ... The code supports more than one led per struct device. ... Please read the FAQ at http://www.tux.org/lkml/ ... Prev by Date: ...
    (Linux-Kernel)
  • Re: kobject oops with maple bus
    ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... very wrong in SLUB or a memory leak in my driver (sadly, ... Yes, you can not free the struct device on your own, you must let the ...
    (Linux-Kernel)
  • Re: [PATCH 45/64] PCIE: remove driver_data direct access of struct device
    ... access to the driver_data pointer in struct device. ... backwards compatible with all older kernel versions. ...
    (Linux-Kernel)
  • Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver
    ... >> You should never create a struct device on the stack. ... creating a struct device that is not dynamically allocated is not ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)