Re: [PATCH] Fix compile error in latest git pull - post 2.6.16-rc1-git4

On Tue, Jan 31, 2006 at 01:29:23PM -0600, Larry Finger wrote:
> After doing a git pull from linux/kernel/git/torvalds/linux-2.6.git, I get
> the following compiler error:
>
> CC net/ipv4/igmp.o
> net/ipv4/igmp.c: In function ‘igmp_rcv’:
> net/ipv4/igmp.c:973: error: label at end of compound statement
>
> Using git bisect, the patch that introduces this error is:
>
> c5d90e000437a463440c1fe039011a02583a9ee5 is first bad commit
> diff-tree c5d90e000437a463440c1fe039011a02583a9ee5 (from
> e2c2fc2c8f3750e1f7ffbb3ac2b885a49416110c)
> Author: Dave Jones <davej@xxxxxxxxxx>
> Date: Mon Jan 30 20:27:17 2006 -0800
>
> [IPV4] igmp: remove pointless printk
>
> This is easily triggerable by sending bogus packets,
> allowing a malicious user to flood remote logs.
>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
>
>
> I suspect this error arises due to differences between gcc 4.0.2 and
> earlier releases. The patch is as follows:

Looks good.

Signed-off-by: Dave Jones <davej@xxxxxxxxxx>

Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Regression impacts ServeRAID II on IBM xSeries 5500
    ... This is my first time reporting a regression. ... According to "git bisect," your patch ... 10db10d144c0248f285242f79daf6b9de6b00a62 is the first bad commit before ... This patch converts the indirect IO path (including mmap IO and old ...
    (Linux-Kernel)
  • Re: [PATCH 03/10] x86: arch/x86/Kconfig.cpu unification
    ... This patch causes build failure on x86_64: ... git bisect gives: ... 55432d383871d127685d78f94e0ad60307dcc0e9 is first bad commit ...
    (Linux-Kernel)
  • Re: [PATCH 03/10] x86: arch/x86/Kconfig.cpu unification
    ... This patch causes build failure on x86_64: ... git bisect gives: ... 55432d383871d127685d78f94e0ad60307dcc0e9 is first bad commit ...
    (Linux-Kernel)
  • Re: [2.6.28-rc] Sata soft reset filling log
    ... Anyways, below is what I get now (with your patch), including the ... ata2: soft resetting link ... I tried to git bisect the problem. ... but the bisect gave inconclusive results because I couldn't tell for sure a good commit from a bad. ...
    (Linux-Kernel)
  • Re: VolanoMark regression with 2.6.27-rc1
    ... I tried to use git bisect to locate the root cause, ... I used my mechanical bisect script linearly to locate below commit: ... If I use web to acces the commit, I could get a big patch. ... BTW, sysbench+mysqlhas about 15% regression, but git bisect looks crazy again. ...
    (Linux-Kernel)