Re: 2.6.16, sk98lin out of date



On Mon, Feb 13, 2006 at 02:03:14PM -0500, Lee Revell wrote:
On Mon, 2006-02-13 at 12:06 +0100, Mws wrote:
hi,
as i do have the same problem i may help you out.

at first, syskonnect did send their kernel diffs/patches but they
we're rejected caused
by coding style, indention and some people thinking that things can be
done better.

Haha, they didn't like the LKML code review so they just stopped sending
patches? Classic. Remind me not to buy their gear.

Lee, it's not always that simple. When you submit one driver, sometimes
reviewers tell you that for whatever reason your driver's structure is
wrong and it has to be changed a lot (and sometimes they're right of
course). But when you don't have enough ressource to do the job twice,
the best you can do is to maintain it out of tree, which is already a
pain. I'm not saying that it is what happened with their driver, I don't
know the history. However, I found your reaction somewhat hasty. I
personally would prefer to offer time and help before deciding that
I don't want anyone's products on this basis. It's not as if they
did not release their driver's source !

Cheers,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: 2.6.16, sk98lin out of date
    ... syskonnect did send their kernel diffs/patches but they ... they didn't like the LKML code review so they just stopped sending ... I'm not saying that it is what happened with their driver, ... researching what the linux kernel coding standards are ahead of time. ...
    (Linux-Kernel)
  • Re: WDF coding style
    ... No there is not a coding style published and hungarian has been proven to be ... Microsoft has conventions that the driver writers use and can be ... Windows Filesystem and Driver Consulting ...
    (microsoft.public.development.device.drivers)
  • Re: [RESEND PATCH 06/10] ide-floppy: report DMA handling in idefloppy_pc_intr() properly
    ... Could you split the above coding style fixes into a separate patch? ... The driver currently doesn't have any fancy features, ... static void idefloppy_blockpc_cmd... ...
    (Linux-Kernel)
  • Re: [2.6 patch] fix a drivers/char/isicom.c compile warning
    ... but I wasn't sure whether changing a driver to be ... > the coding style used in the rest of the driver is really an ... pain in the ass for the maintainer, that should try to follow CodingStyle, but ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths
    ... ^ Contains additional whitespace. ... Its an old driver, it doesn't follow the coding style too well at all - ... viz stuff like if (! ...
    (Linux-Kernel)