Re: 2.6.16, sk98lin out of date

On Mon, 2006-02-13 at 21:34 +0100, Willy Tarreau wrote:
On Mon, Feb 13, 2006 at 02:03:14PM -0500, Lee Revell wrote:
On Mon, 2006-02-13 at 12:06 +0100, Mws wrote:
hi,
as i do have the same problem i may help you out.

at first, syskonnect did send their kernel diffs/patches but they
we're rejected caused
by coding style, indention and some people thinking that things can be
done better.

Haha, they didn't like the LKML code review so they just stopped sending
patches? Classic. Remind me not to buy their gear.

Lee, it's not always that simple. When you submit one driver, sometimes
reviewers tell you that for whatever reason your driver's structure is
wrong and it has to be changed a lot (and sometimes they're right of
course). But when you don't have enough ressource to do the job twice,
the best you can do is to maintain it out of tree, which is already a
pain. I'm not saying that it is what happened with their driver, I don't
know the history. However, I found your reaction somewhat hasty. I
personally would prefer to offer time and help before deciding that
I don't want anyone's products on this basis. It's not as if they
did not release their driver's source!

True, that was a little harsh. I just find it a little sad that all
these vendors insist on throwing away months of work rather than simply
researching what the linux kernel coding standards are ahead of time.

Lee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: 2.6.16, sk98lin out of date
    ... syskonnect did send their kernel diffs/patches but they ... by coding style, indention and some people thinking that things can be ... they didn't like the LKML code review so they just stopped sending ... I'm not saying that it is what happened with their driver, ...
    (Linux-Kernel)
  • Re: ucam device in FreeBSD?
    ... I have no high hopes for my own coding skills either. ... However, if I was going to create a kernel module, say fr my SPCA5xx based camera, it would be nuice to have something to look at. ... is under the GPL license (being based on the Linux driver, it needs to be, so that is understandable). ... I would prefer to look at such a module instead, that way I could create my module under a BSD license. ...
    (comp.unix.bsd.freebsd.misc)
  • BSDstats Project: Our ultimate goal ...
    ... those that have provided suggestions on both what should be included, as well as some of the coding that has been used (my shell scripting isn't as strong as my perl / php *sigh*) ... ... and what vendors/chipsets ... ... the pcib driver is used twice, as is the atapci driver ... ...
    (freebsd-questions)