Re: [linux-pm] [PATCH 3/5] [pm] Respect the actual device power states in sysfs interface


On Sun, 19 Feb 2006, Greg KH wrote:

On Sun, Feb 19, 2006 at 03:59:25PM -0800, Patrick Mochel wrote:

On Sat, 18 Feb 2006, Pavel Machek wrote:

Hi!

Fix the per-device state file to respect the actual state that
is reported by the device, or written to the file.

Can we let "state" file die? You actually suggested that at one point.

I do not think passing states in u32 is good idea. New interface that passes
state as string would probably be better.

Yup, in the future that will be better. For now, let's work with what we
got and fix 2.6.16 to be compatible with previous versions..

It's _way_ too late in the 2.6.16 cycle for this series of patches, if
that is what you are proposing.

Would you mind commmenting on why, as well as your opinion on the validity
of the patches themselves?

This static, hardcoded policy was introduced into the core ~2 weeks ago,
and it doesn't seem like it belongs there at all. This seems like the
easiest way to fixing it, but I'm open to alternative suggestions..

Thanks,


Pat
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH] Documentation/stable_kernel_rules.txt: Clarification
    ... On Sun, 29 Jan 2006, Greg KH wrote: ... > People complained that we immediatly abandonded the last stable kernel ... > going to accept patches for "any" kernel release. ...
    (Linux-Kernel)
  • -mm merge plans for 2.6.24
    ... Might drop these patches. ... Send to jgarzik ... Send to whichever of Greg and drzeus ends up needing it. ... Will repoll people. ...
    (Linux-Kernel)
  • Solaris 10 patching
    ... patch aquisition method. ... I was first told to enter my Sun Online Account details. ... When it came to the patches though, ... For customers with a Sun Service plan you can make use of the free ...
    (comp.unix.solaris)
  • Sun patches broke my KVM!
    ... The patches worked great and I ... patches my KVM mouse/track-pad stopped working on all the systems! ... Sun compatible. ... connected to the systems via USB and the Monitor. ...
    (comp.sys.sun.hardware)
  • Re: Sun Patches timetable
    ... >>> installing the latest patch clusters from Sun. ... >> My team applies patches each quarter. ... >> mission critical systems, so by the time the most critical systems have ...
    (Focus-SUN)