Re: [PATCH] Convert serial_core oopses to BUG_ON
- From: Russell King <rmk+lkml@xxxxxxxxxxxxxxxx>
- Date: Sun, 26 Feb 2006 22:41:45 +0000
On Sun, Feb 26, 2006 at 11:34:48PM +0100, Karol Kozimor wrote:
Thus wrote Russell King:
"until" - I think you mean "if anyone ever bothers" so no I don't agree.Calling serial functions to flush buffers, or try to send more data
after the port has been closed or hung up is a bug in the code doing
the calling, not in the serial_core driver.
Make this explicitly obvious by adding BUG_ON()'s.
If we make it
if (!info) {
WARN_ON(1);
return;
}
will that allow people's kernels to limp along until it gets fixed?
Russel, I agree this should be clearly marked and an oops seems okay here,
but we're talking dead systems here (dead as in all interrupts masked type
of dead). Most users won't even be aware an oops occured, let alone be able
to read the messages on the console.
I was just lucky because after the first one I got (#5958, a regular oops)
I tried to nail it down in text mode, with the console loglevel upped a
bit, so I was able to see what the panic (#6131) was all about.
I think we really need those *_ON()s at least in uart_write().
I don't think it'll make a blind bit of difference. The oopses have
been known about (to me and others) since about October 2005... Pavel
Machek was the first to report the hci_uart problems.
I diagnosed the uart_flush_buffer() oops being caused by hci_uart back
in October and where did that get us - nowhere at the time, but later
another bug report in bugzilla against serial and no progress.
Excuse me if I'm despondent on this issue - I'm personally looking for
a way out of being assigned blame for the crap known as hci_uart.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: [PATCH] Convert serial_core oopses to BUG_ON
- From: Karol Kozimor
- Re: [PATCH] Convert serial_core oopses to BUG_ON
- Prev by Date: Re: 2.6.15-rt17
- Next by Date: Re: Building 100 kernels; we suck at dependencies and drown in warnings
- Previous by thread: Re: [PATCH] Convert serial_core oopses to BUG_ON
- Next by thread: block/floppy: fix section mismatch warnings
- Index(es):
Relevant Pages
|
