Re: [PATCH 3/7] inflate pt1: clean up input logic

On Mon, Feb 27, 2006, Russell King wrote:
On Mon, Feb 27, 2006 at 02:18:44AM +0100, Johannes Stezenbach wrote:
On Sat, Feb 25, 2006 at 10:57:49PM +0000, Russell King wrote:
The email:

http://www.ussg.iu.edu/hypermail/linux/kernel/0312.2/1024.html

contains a full and clear explaination of the situation. The second
paragraph of that email is key to understanding the problem and makes
it absolutely clear what is trying to be decompressed as the initrd
(the corrupted compressed piggy).

FWIW, I didn't it either. "Work around broken boot firmware which passes
invalid initrd to kernel" would have been a simpler description.

Sigh, I'm sick of this crap. I'm not going to debate it any further.

I agree that it would be nice if inflate.c would fail gracefully
instead of halting,

IT _DOES_ FAIL GRACEFULLY TODAY. WITH MATT'S PATCHES, IT _DOESN'T_.
THAT'S A REGRESSION. WHAT IS IT ABOUT THAT WHICH PEOPLE DON'T
UNDERSTAND? DO I HAVE TO SPELL IT OUT IN ONE SYLLABLE WORDS?

I got that already, no need to shout. I just wanted to point
out that from the information you provided so far it
looks like your problem could be fixed in a more straight
forward fashion.

Problem: Boot firmware passes invalid arguments.
Solution: Ignore invalid boot firmware arguments.

but why can't you just use CONFIG_BLK_DEV_INITRD=n?

Because you might want to use an initrd for real (for installation
purposes) and therefore distributions (eg Debian) want it turned on?

If you use a distribution kernel which contains one, you
could simply add "noinitrd" to the kernel command line
to ignore it, no?

Okay, this does it - I'm ignoring further discussion on this stupid
idiotic topic which is soo bloody difficult for others to understand.

I don't understand your aggressiveness, there must be a dark
secret behind all this. Or maybe it's just the season
for flame wars.


I'm sorry to have bothered you,
Johannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 3/7] inflate pt1: clean up input logic
    ... invalid initrd to kernel" would have been a simpler description. ... Boot firmware passes invalid arguments. ... The kernel does not have such functionality, ... if we have to have separate code to validate a compressed image, ...
    (Linux-Kernel)
  • Re: booting from ISO image on HD?
    ... >> through customized initrd files for each one. ... > between the loopback device and the underlying file (the iso image). ... I have to insmod the loop kernel module(e.g. ... how can you boot it from an initrd??? ...
    (comp.os.linux.misc)
  • Re: fsck fails during boot with 2.6.9-34.0.1.EL kernel because root filesystem is already rw mou
    ... I think there was a little fault in building the new initrd. ... The mount-command of the init-script is wrong and makes confusing, e.g.: first the root-filesystem must mount read/write, it accepts. ... It looks like in the early stage of the booting, when the kernel is using the initrd to load the ... I still do not understand why in my new initrd file, with the new kernel, the root filesystem is ...
    (RedHat)
  • Re: weeding out c++ keywords from sys/sys
    ... Can you mention exactly which links were invalid for you? ... any movement within the Linux community to bring C++ support into the kernel. ... should be used as a framenwork for C-like processing segments. ... I would like to go even further and make the framework actually ...
    (freebsd-current)
  • Re: booting from ISO image on HD?
    ... I'm not going to write the pivot root script, ... > through customized initrd files for each one. ... I have to insmod the loop kernel module(e.g. ... The idea is that either you build what you need to boot into your ...
    (comp.os.linux.misc)