Re: [PATCH] Enable mprotect on huge pages

On Tue, Feb 28, 2006 at 11:23:54AM +0800, Zhang, Yanmin wrote:
On Tue, 2006-02-28 at 09:34, Andrew Morton wrote:
"Zhang, Yanmin" <yanmin_zhang@xxxxxxxxxxxxxxx> wrote:

2.6.16-rc3 uses hugetlb on-demand paging, but it doesn_t support hugetlb
> > > > mprotect. My patch against 2.6.16-rc3 enables this capability.

Based on David's comments, I worked out a new patch against 2.6.16-rc4.
Thank David.


Please always send an updated changelog when sending an updated patch.
Otherwise I have to go trolling back through the email thread to find it,
then work out what needs to be changed.
Thanks for your kind reminder. I would do so next time.



I tested it on i386/x86_64/ia64. Who could help test it on other
platforms, such like PPC64?

I can do that - please send me your test app?
I attach a test case. It will create directory /mnt/hugepages and delete it
after testing automatically.

To run it by user root:
#gcc -o mprotect_testcase mprotect_testcase.c
#echo "5">/proc/sys/vm/nr_hugepages
#./mprotect_testcase

If you could adapt this testcase to fit into the libhugetlbfs
testsuite, that would be really great (from
git://ozlabs.org/~dgibson/git/libhugetlbfs.git). Otherwise I guess I
will..

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • [ANNOUNCE] qgit-1.2
    ... With qgit you will be able to browse revisions history, view patch content ... View revisions, diffs, files history, files annotation, archive tree. ... For a complete changelog see shipped ChangeLog file or git repository ...
    (Linux-Kernel)
  • [PATCH 0/6] Add some trace events for the page allocator v5
    ... Changelog since V4 ... Make the post-processing script more robust against format changes. ... Add CPU information to the per-cpu tracepoints information ... Patch 1 adds events for plain old allocate and freeing of pages ...
    (Linux-Kernel)
  • [PATCH 0/6] Add some trace events for the page allocator v6
    ... This is V6 of a patchset to add some tracepoints of interest when analysing ... Changelog since V4 ... Make the post-processing script more robust against format changes. ... Patch 1 adds events for plain old allocate and freeing of pages ...
    (Linux-Kernel)
  • Re: Unable to continue testing of 2.6.25
    ... Sadly that does a TOTAL flush of the caches of all ... That's a much better explanation than can be found in the changelog. ... I did actually manage to create such a patch for the breakage in the ... patches for unreleased kernel versions. ...
    (Linux-Kernel)
  • Re: [PATCH] Enable mprotect on huge pages
    ... I worked out a new patch against 2.6.16-rc4. ... Please always send an updated changelog when sending an updated patch. ... Who could help test it on other ... tested EXEC transitions yet, that's hairier). ...
    (Linux-Kernel)