Re: [PATCH] Fixup ahci suspend / resume

Jens Axboe wrote:
Upstream 2.6.x certainly _does_ care about suspend/resume! To me, this
patch seems simple enough to be included. It's little more than
splitting the register init out form the port_stop/start functions and
calling them on resume/suspend appropriately.

Upstream _libata_ doesn't care much about suspend/resume. Officially, its a work in progress with major pieces -- your patch and ACPI -- still missing.

Further, good improvements covering some of the changes in Hannes' patch are already in #upstream.

Thus, it's more work than its worth to care about the patch as-is. It should be redone against #upstream, which is where all suspend/resume development is occurring.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [patch] Add the device IDs for AMD/ATI SB700
    ... Since Jeff covered both status of your patches and administrative issues ... It makes sense to put addition of _all_ new PCI IDs into the first patch ... and without maintainers worrying about your patches not applying cleanly. ... When you don't see a patch in the upstream git tree ...
    (Linux-Kernel)
  • =?utf-7?B?UkU6ICtBRnMtcGF0Y2grQUYwLSBBZGQgdGhlIGRldmljZSBJRHMgZg==?= =?utf-7?B?b3IgQU1EL0FUS
    ... Since Jeff covered both status of your patches and administrative issues ... and without maintainers worrying about your patches not applying cleanly. ... When you don't see a patch in the upstream git tree ...
    (Linux-Kernel)
  • Re: [patch] Add the device IDs for AMD/ATI SB700
    ... then the next step is consult the MAINTAINERS file, and determine to whom you should send a follow-up patch, or simply contact about the status of a patch you just sent. ... That tells us the maintainer of the subsystem, and also an external reference (a tree) to where the maintainer posts accepted patches, prior to sending them upstream. ...
    (Linux-Kernel)
  • Re: [PATCH] Fixup ahci suspend / resume
    ... Of course I will regenerate is against #upstream. ... Updated patch to follow. ... ahci: ... unsigned int port_idx) ...
    (Linux-Kernel)
  • Re: [stable] [patch 29/37] dvb-core: Proper handling ULE SNDU length of 0
    ... fix the bug and has been tested on version 2.6.17.11. ... kernel will produce a dump during CRC32 checking on faulty ULE packet. ... upstream code might be still vulnerable. ... So we should not take this patch for 2.6.17.y? ...
    (Linux-Kernel)