[PATCH 3/8] saa7114: Fix i2c block write
- From: Jean Delvare <khali@xxxxxxxxxxxx>
- Date: Mon, 13 Mar 2006 21:30:53 +0100
Fix the i2c block write mode of the saa7114 driver. A previous code
change accidentally commented out a local variable increment, which
should have been kept, causing the register writes over the I2C bus
to never be batched, replacing any attempted block write by slower,
individual write transactions.
Also drop the commented out code, as it only adds to confusion.
Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
---
drivers/media/video/saa7114.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
--- linux-2.6.16-rc5.orig/drivers/media/video/saa7114.c 2006-03-01 21:09:59.000000000 +0100
+++ linux-2.6.16-rc5/drivers/media/video/saa7114.c 2006-03-01 21:10:10.000000000 +0100
@@ -138,9 +138,6 @@
u8 reg,
u8 value)
{
- /*struct saa7114 *decoder = i2c_get_clientdata(client);*/
-
- /*decoder->reg[reg] = value;*/
return i2c_smbus_write_byte_data(client, reg, value);
}
@@ -156,7 +153,6 @@
* the adapter understands raw I2C */
if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
/* do raw I2C, not smbus compatible */
- /*struct saa7114 *decoder = i2c_get_clientdata(client);*/
struct i2c_msg msg;
u8 block_data[32];
@@ -167,8 +163,8 @@
msg.len = 0;
block_data[msg.len++] = reg = data[0];
do {
- block_data[msg.len++] =
- /*decoder->reg[reg++] =*/ data[1];
+ block_data[msg.len++] = data[1];
+ reg++;
len -= 2;
data += 2;
} while (len >= 2 && data[0] == reg &&
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 0/8] Zoran drivers updates
- From: Jean Delvare
- [PATCH 0/8] Zoran drivers updates
- Prev by Date: Re: [PATCH] scm: fold __scm_send() into scm_send()
- Next by Date: Re: New libata PATA patch for 2.6.16-rc1
- Previous by thread: [PATCH 4/8] adv7175: Drop unused encoder dump command
- Next by thread: [PATCH 5/8] adv7175: Drop unused register cache
- Index(es):
Relevant Pages
|
Loading
