Re: [PATCH 7/14] RTC: Remove RTC UIP synchronization on MIPS Footbridge
- From: Matt Mackall <mpm@xxxxxxxxxxx>
- Date: Fri, 17 Mar 2006 17:58:56 -0600
On Fri, Mar 17, 2006 at 05:30:36PM -0600, Matt Mackall wrote:
Remove RTC UIP synchronization on MIPS Footbridge
Urgh, this is obviously ARM. And I noticed my per-patch cc:es got
lost.
Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>
Index: rtc/arch/arm/mach-footbridge/time.c
===================================================================
--- rtc.orig/arch/arm/mach-footbridge/time.c 2005-10-27 19:02:08.000000000 -0500
+++ rtc/arch/arm/mach-footbridge/time.c 2006-03-12 13:00:51.000000000 -0600
@@ -34,27 +34,12 @@ static int rtc_base;
static unsigned long __init get_isa_cmos_time(void)
{
unsigned int year, mon, day, hour, min, sec;
- int i;
// check to see if the RTC makes sense.....
if ((CMOS_READ(RTC_VALID) & RTC_VRT) == 0)
return mktime(1970, 1, 1, 0, 0, 0);
- /* The Linux interpretation of the CMOS clock register contents:
- * When the Update-In-Progress (UIP) flag goes from 1 to 0, the
- * RTC registers show the second which has precisely just started.
- * Let's hope other operating systems interpret the RTC the same way.
- */
- /* read RTC exactly on falling edge of update flag */
- for (i = 0 ; i < 1000000 ; i++) /* may take up to 1 second... */
- if (CMOS_READ(RTC_FREQ_SELECT) & RTC_UIP)
- break;
-
- for (i = 0 ; i < 1000000 ; i++) /* must try at least 2.228 ms */
- if (!(CMOS_READ(RTC_FREQ_SELECT) & RTC_UIP))
- break;
-
- do { /* Isn't this overkill ? UIP above should guarantee consistency */
+ do {
sec = CMOS_READ(RTC_SECONDS);
min = CMOS_READ(RTC_MINUTES);
hour = CMOS_READ(RTC_HOURS);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 1/14] RTC: Remove RTC UIP synchronization on x86
- From: Matt Mackall
- [PATCH 7/14] RTC: Remove RTC UIP synchronization on MIPS Footbridge
- From: Matt Mackall
- [PATCH 1/14] RTC: Remove RTC UIP synchronization on x86
- Prev by Date: Re: [v4l-dvb-maintainer] Re: [PATCH 05/21] Added no_overlay option and quirks to saa7134
- Next by Date: kernel BUG at drivers/block/loop.c:621
- Previous by thread: [PATCH 7/14] RTC: Remove RTC UIP synchronization on MIPS Footbridge
- Next by thread: [PATCH 14/14] RTC: Remove some duplicate BCD definitions
- Index(es):
Relevant Pages
|
|
