Re: [PATCH 000/141] V4L/DVB updates part 1





On Tue, 21 Mar 2006, Mauro Carvalho Chehab wrote:

Looking closer, the commit after that is a _real_ merge, and it looks like
you did something strange when that at first conflicted in saa7134-dvb.c
or something. I just don't even see _how_ you created that bogus non-merge
commit. Are you using cogito? It has some problems with conflict
resolution, I think. Real git should not even have allowed you to commit
something that hadn't been resolved.

I'm using stgit. It allows me to export the patches from V4L/DVB
Mercurial tree, removing backward compatible code and correcting the
patches. Is it broken?

Hmm. I don't know if it's stgit per se. Maybe the breakage came from a
mercurial merge that got exported to git as a patch, rather than as a
merge.

If that's the case, then I'm afraid that the problem is the mercurial
part, or at least the hg->git conversion. I have no idea how hg does
merges, and maybe the broken merge was done in the hg tree.

The really sad part about this is that it means I have to be much more
careful with dvb merges, since I can't trust the tree any more, when it
apparently has something strange going on. If things like this keep on
happening, I'll have to ask you guys to change your work habits.

That said, I _tried_ to check for similar cases in the past history, and I
couldn't find any. So hopefully this was a one-off occurrence.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH 000/141] V4L/DVB updates part 1
    ... I'm using stgit. ... It allows me to export the patches from V4L/DVB ... Maybe I'm using a bad procedure to keep my -git tree. ... git pull linus_tree ...
    (Linux-Kernel)
  • Re: the weird card rarely believes Chester, it kicks Edith instead
    ... Just now Yani will tease the coffee, ... the tree will improve before the distant cave. ... Bert will wanly change afterwards. ... For Gavin the film's strange, below me it's cheap, whereas in front of you it's ...
    (rec.pets.cats.anecdotes)
  • Re: [ACPI] [PATCH] i386 No Idle HZ aka dynticks v051205
    ... > If you get strange stalls with this patch then almost certainly it is a ... > Split out patches, timertop and pmstats utilities and latest patch available ... > What Hz should I use with dynticks in the config? ... > 1000 to realise the benefits of the power saving features and low latency. ...
    (Linux-Kernel)
  • Re: Something rotten in the state of SunSolve?
    ... Chris Thompson wrote: ... > strange that no-one else seems to be seeing this. ... Another problem which comes and goes is that sometimes new patches ... or patch revisions are in the most recent patchdiag.xref, ...
    (comp.unix.solaris)
  • Re: Textbox control question
    ... the basic requirements I outlined earlier. ... the only thing strange I ... or am I barking up the wrong tree. ... If my logic is faulty, ...
    (microsoft.public.vb.general.discussion)