Re: Two comments on the H.323 conntrack/NAT helper

[The hotmail address of the author doesn't work, CCed sourceforge-address]

Adrian Bunk wrote:
Two comments on the H.323 conntrack/NAT helper:
- the function prototypes in ip_nat_helper_h323.c are _ugly_,
please move them to a header file

Their ugliness is because of the current API, which cleaned up
quite a lot of the surrounding code, but requires this ugliness
from each helper. I would like to keep them visible as a reminder
that a cleaner solution is wanted, but moving them to header
files certainly sound like a good idea to eliminate the risk
of prototype conflicts. But please do this for all helpers
at once.

- is there a reason for not using EXPORT_SYMBOL_GPL?

I would prefer that too.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Two comments on the H.323 conntrack/NAT helper
    ... Two comments on the H.323 conntrack/NAT helper ... Adrian Bunk wrote: ... please move them to a header file ... quite a lot of the surrounding code, ...
    (Linux-Kernel)
  • Re: Mail Merge Header file?
    ... They aren't really supported any more and there can be problems using them, but you can still do so either by reviving the old Mail Merge Helper (Tools|Customize, select category All Commands, locate Mail Merge Helper in the list of commands, and drag it to a toolbar, e.g. the Mail Merge toolbar.) or using ActiveDocument.MailMerge.OpenHeaderSource in VBA. ... can't figure out how to change what header file I want to point too. ...
    (microsoft.public.word.mailmerge.fields)
  • Re: Two comments on the H.323 conntrack/NAT helper
    ... Two comments on the H.323 conntrack/NAT helper ... Adrian Bunk wrote: ... please move them to a header file ... quite a lot of the surrounding code, ...
    (Linux-Kernel)
  • Re: Win32-API function calls in VS2005 CLR applications
    ... using windows.h or a similar header file: ... for anything nasty - so if you need to interface with lots of native ... C++/CLI is a much cleaner solution. ...
    (microsoft.public.dotnet.languages.vc)