Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- From: jamal <hadi@xxxxxxxxxx>
- Date: Fri, 24 Mar 2006 09:11:58 -0500
On Fri, 2006-24-03 at 07:02 +0530, Balbir Singh wrote:
On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote:
3. nlmsg_new() now allocates for 2*u32 + sizeof(taskstats)
Not the right size; the u32 covers the V part of TLV. The T = 16 bits
and L = 16 bits. And if you nest TLVs, then it gets more interesting.
Look at using proper macros instead of hard coding like you did.
grep for something like RTA_SPACE and perhaps send a patch to make it
generic for netlink.h
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- [Patch 0/9] Per-task delay accounting
- From: Shailabh Nagar
- [Patch 9/9] Generic netlink interface for delay accounting
- From: Shailabh Nagar
- Re: [Patch 9/9] Generic netlink interface for delay accounting
- From: Matt Helsley
- Re: [Patch 9/9] Generic netlink interface for delay accounting
- From: jamal
- [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- From: Balbir Singh
- Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- From: jamal
- Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- From: Balbir Singh
- [Patch 0/9] Per-task delay accounting
- Prev by Date: Re: [2.6.16-mm1 patch] throttling tree patches
- Next by Date: Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- Previous by thread: Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- Next by thread: Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- Index(es):
Relevant Pages
|