Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting

On Sat, 2006-25-03 at 23:52 +0530, Balbir Singh wrote:


No, we cannot have both passed. If we pass both a PID and a TGID and
then the code returns just the stats for the PID.


ok, that clears it then; i think you are ready to go.


Also in regards to the nesting, isnt there a need for nla_nest_cancel in
case of failures to add TLVs?


I thought about it, but when I looked at the code of genlmsg_cancel()
and nla_nest_cancel(). It seemed that genlmsg_cancel() should
suffice.


If your policy is to never send a message if anything fails, then you
are fine.

What would be really useful now that you understand this, is if you can
help extending/cleaning the document i sent you. Or send me a table of
contents of how it would have flowed better for you.

cheers,
jamal



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages