Re: [PATCH] rtc: Added support for ds1672 control

On Tue, 28 Mar 2006 16:04:20 -0600
Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> wrote:

Not sure if I follow you here. I think you are suggesting for
ds1672_get_control to look like:

static int ds1672_get_control(struct i2c_client *client, u8 *status)
{
unsigned char addr = DS1672_REG_CONTROL;

struct i2c_msg msgs[] = {
{ client->addr, 0, 1, &addr }, /* setup
read ptr */
{ client->addr, I2C_M_RD, 1, status }, /* read
control */
};
...
}

yes.


which is fine. Any suggestions on what to do on an error in the
sysfs attrib function?

i2c_transfer will give the errno to return back.
This remembers me that I forgot to do that in other drivers :(

--

Best regards,

Alessandro Zummo,
Tower Technologies - Turin, Italy

http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages