Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- From: Roland Dreier <rdreier@xxxxxxxxx>
- Date: Tue, 04 Apr 2006 17:42:20 -0700
David> You were using an interface in an unintended way.
There were a lot of opportunities to suggest a better way or even just
raise the alarm when IPoIB was first being reviewed. And I don't
remember anyone giving any guidance or insight into the neighbour
destructor design the three or four times Michael raised the issue of
the IPoIB crash and posted this patch for review....
David> Do you know %100 for certain that moving that callback to a
David> different location won't break anything?
Of course it's not %100 certain, but it definitely fixes a panic in
IPoIB, and the clip.c change looks "obviously correct."
If this patch is too risky for -stable, that's fine. But let's be
clear that it _does_ fix a panic people hit in practice, and as far as
I know it doesn't break the ATM build
- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- From: David S. Miller
- Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- References:
- [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- From: gregkh
- Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- From: David S. Miller
- Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- From: Roland Dreier
- Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- From: David S. Miller
- [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- Prev by Date: RE: [Fastboot] [PATCH] kexec on ia64
- Next by Date: Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- Previous by thread: Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- Next by thread: Re: [patch 11/26] IPOB: Move destructor from neigh->ops to neigh_param
- Index(es):
Relevant Pages
|
