Re: IP1000 gigabit nic driver

On Sat, 2006-04-29 at 14:21 +0200, David Gómez wrote:
I already had it modified, just needed to create the patch... Anyway,
have you submitted it to netdev?

On Sat, 2006-04-29 at 23:35 +0300, Pekka Enberg wrote:
No, I haven't. I don't have the hardware, so I can't test the driver.
Furthermore, there's plenty of stuff to fix before it's in any shape for
submission. If someone wants to give this patch a spin, I would love to
hear the results.

I killed the I/O write/read macros and switched the driver to iomap.

Pekka

Subject: [PATCH] IP1000 Gigabit Ethernet device driver

This is a cleaned up fork of the IP1000A device driver:

<http://www.icplus.com.tw/driver-pp-IP1000A.html>

Open issues include but are not limited to:

- ipg_probe() looks really fishy and doesn't handle all errors
(e.g. ioremap failing).
- ipg_nic_do_ioctl() is playing games with user-space pointer.
We should use ethtool ioctl instead as suggested by Arjan.
- For multiple devices, the driver uses a global root_dev and
ipg_remove() play some tricks which look fishy.

I don't have the hardware, so I don't know if I broke anything.
The patch is 138 KB in size, so I am not including it in this
mail. You can find the patch here:

http://www.cs.helsinki.fi/u/penberg/linux/ip1000-driver.patch

Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 6/7] ppc64: EEH Avoid racing reports of errors
    ... Yes; that's right; this gets fixed in a later patch in the series. ... One problem I was seeing was that after getting an EEH error, ... depends on how the device driver got written. ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • [PATCH] Dump partition list on inability to mount /
    ... The attached patch dumps a list of partitions (in a similar ... One of the annoying things about the fail to mount / panics is that you ... can no longer scroll up to find out what errors came from device driver ...
    (Linux-Kernel)
  • Re: [BUG or cosmic ray] WARNING: at net/sched/sch_generic.c:222 dev_watchdog+0xe8/0x100()
    ... With this patch the device driver can at least try to initialize. ... on a .22 kernel came out the same lspci error: ... linux-kernel or linux-pci will probably be more helpful than ...
    (Linux-Kernel)
  • Slow after Windows Update
    ... I found the patch that was causing my machine to slow down. ... >I have re-installed spk4. ... >see why I have to pay for it, ... but my device driver is fine. ...
    (microsoft.public.win2000.general)
  • [PATCH] add a trivial patch style checker v2
    ... These detract from the quality of the submission and cause unnessary ... As a first step package up the current state of the patch style ... Check for trivial violations with the ...
    (Linux-Kernel)