[patch 01/14] Fix comment about remap_file_pages
- From: blaisorblade@xxxxxxxx
- Date: Sun, 30 Apr 2006 19:29:54 +0200
From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
This comment is a bit unclear and also stale. So fix it. Thanks to Hugh Dickins
for explaining me what it really referred to, and correcting my first fix.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
Index: linux-2.6.git/mm/fremap.c
===================================================================
--- linux-2.6.git.orig/mm/fremap.c
+++ linux-2.6.git/mm/fremap.c
@@ -208,9 +208,10 @@ asmlinkage long sys_remap_file_pages(uns
pgoff, flags & MAP_NONBLOCK);
/*
- * We can't clear VM_NONLINEAR because we'd have to do
- * it after ->populate completes, and that would prevent
- * downgrading the lock. (Locks can't be upgraded).
+ * We would like to clear VM_NONLINEAR, in the case when
+ * sys_remap_file_pages covers the whole vma, so making
+ * it linear again. But cannot do so until after a
+ * successful populate, and have no way to upgrade sem.
*/
}
if (likely(!has_write_lock))
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [patch 00/14] remap_file_pages protection support
- From: blaisorblade
- [patch 00/14] remap_file_pages protection support
- Prev by Date: [patch 12/14] remap_file_pages protection support: also set VM_NONLINEAR on nonuniform VMAs
- Next by Date: [patch 09/14] remap_file_pages protection support: fix race condition with concurrent faults on same address space
- Previous by thread: [patch 12/14] remap_file_pages protection support: also set VM_NONLINEAR on nonuniform VMAs
- Next by thread: [patch 09/14] remap_file_pages protection support: fix race condition with concurrent faults on same address space
- Index(es):