RE: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available (2nd revision)





Thomas Kleffel (maintech GmbH) wrote:
+ if(is_mmio)
+ my_outb = outb_mem;
+ else
+ my_outb = outb_io;

David Vrabel wrote:
Shouldn't you convert ide_cs to use iowrite8 (and friends) instead of
doing this?


Actually, I think even better to use the primitives from ide-iops.c ?

i.e. the members of default_hwif_iops and default_hwif_mmiops, which
map to the ide_mm_outb and ide_outb functions used by the rest of the
IDE driver code?

- Iain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: Xilinx Virtex-4 BRAM-16 Simulation
    ... I did not see there the RAMB_Sx_Sy primitives of Spartan yore, ... Spartan3s and Virtex-4 effortlessly. ... Is this a glitch in the 8.1 simulator? ... generic map ( ...
    (comp.arch.fpga)
  • Re: concurrent and atomic map?
    ... > I'm confused by the concurrent map offering for Java 1.5. ... I have used the gnu maps that allow primitives. ... The keys of the map must be an ...
    (comp.lang.java.help)
  • Re: Desktop <-> Web
    ... I think it's probably better to think of JSON as simple primitives. ... Thus JSON's "object" would map to Ruby's Hash. ... create an output method that translates my objects to primitives and ...
    (comp.lang.ruby)
  • Re: Is there a simple way to transform window coordinates to opengl coordinates ?
    ... map it into the 3D world co-ordinates, ... If your goal is to 'pick' from one of the primitives, ... plus the OpenGL red book: ...
    (comp.graphics.visualization)
  • Changing coordinate system from bottom left to upper left?
    ... I'm using 2D/Sprite class graphics, but have a need to draw some 3d ... primitives on top of my 2d map. ... How do I render my 3d primitives such that the upper left hand corner ...
    (microsoft.public.win32.programmer.directx.managed)