Please revert git commit 1ad3dcc0

From: Bernd Schmidt <bernds_cb1@xxxxxxxxxxx>
Date: Tue, 16 May 2006 13:23:39 +0200

Linus, Andrew,

please revert 1ad3dcc0. That was a patch to the binfmt_flat loader, which was motivated by an LTP testcase which checks that execve returns EMFILE when the file descriptor table is full.

The patch is buggy: the code now keeps file descriptors open for the executable and its libraries, which has confused at least one application. It's also unnecessary, since there is no code that uses the file descriptor, so the new EMFILE error return is totally artificial.

The reversion is
Signed-off-by: Bernd Schmidt <bernd.schmidt@xxxxxxxxxx>
Signed-off-by: Greg Ungerer <gerg@xxxxxxxxxxx>
and I think Luke had no objections either.

Bernd
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Follow-Ups:
- Re: Please revert git commit 1ad3dcc0
  - From: Andrew Morton

Prev by Date: Re: [PATCH] mm: cleanup swap unused warning
Next by Date: Re: need a small help guys - need a file in linux
Previous by thread: [PATCH] oprofile: convert from semaphores to mutexes
Next by thread: Re: Please revert git commit 1ad3dcc0
Index(es):
- Date
- Thread

Relevant Pages

Re: Please revert git commit 1ad3dcc0
... which was motivated by an LTP testcase which checks that execve returns ... EMFILE when the file descriptor table is full. ... The patch is buggy: the code now keeps file descriptors open for the ...
(Linux-Kernel)
Re: [PATCH] Use userland-like functions for reading the ACPI table
... especially since it depends on thread-global state (the file descriptor ... I *also* think this patch is just fundamentally broken regardless. ... So I would NAK this patch - it looks buggy, and the reason for it is not ...
(Linux-Kernel)
Re: Change select(2) to kevent(2) on script(1)...
... devices' (svn commit: r185942). ... 'master' file descriptor ... Are you planning to commit the patch for scriptto SVN? ...
(freebsd-current)
Re: Change select(2) to kevent(2) on script(1)...
... devices' (svn commit: r185942). ... 'master' file descriptor ... Are you planning to commit the patch for scriptto SVN? ...
(freebsd-current)
Re: [RCF] [PATCH] unprivileged mount/umount
... When a file descriptor is sent from one process to other, ... attached a patch that can fix the problem, ... send the line "unsubscribe linux-kernel" in ...
(Linux-Kernel)