Re: [RFC]disable msi mode in pci_disable_device

Andrew Morton wrote:
In
his usage, pci_save_state will be called at runtime, and later (after
the device operates for some time and has an error) pci_restore_state
will be called.

Is that a sane thing for a driver to be doing? (Not relevant to this issue
though).

The aim is to be able to recover from a memory parity error in the NIC.
Such errors happen sometimes, especially when a cosmic ray comes by. To
recover, we restore the state that we saved at the end of the
initialization. As saving currently disables MSI, we currently have to
restore the state right after saving it at the end of the initialization
(see the end of
myri10ge_probe in http://lkml.org/lkml/2006/5/23/24).

I just tried, the patch fixes our problem (no need to restore right
after saving to reenable MSI).

Brice

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [RFC]disable msi mode in pci_disable_device
    ... The aim is to be able to recover from a memory parity error in the NIC. ... As saving currently disables MSI, ... restore the state right after saving it at the end of the initialization ...
    (Linux-Kernel)
  • Re: [RFC]disable msi mode in pci_disable_device
    ... As saving currently disables MSI, ... restore the state right after saving it at the end of the initialization ... After a cold boot, some initialization is done by Linux before the ...
    (Linux-Kernel)
  • Re: Trouble keeping records straight for a mail merge -data from A
    ... you are using) "System Restore" to try to get your system back to the ... pages (candidate ltr, client ltr and an invoice page); ... I have been saving each one with the appropriate ... candidate information left checked in the mail merge and doing a save ...
    (microsoft.public.word.mailmerge.fields)
  • Re: initialization of weights and bias of neural network
    ... I want to establish several neural network models. ... Now I want to restore the initialization when a new model is to be ... greg-heath RNG ...
    (comp.soft-sys.matlab)
  • Re: Kernel panic - every three weeks
    ... want to restore to the state at the point of the crash, ... So you'd be saving state every five minutes... ... Perhaps a per-app save state (I think if you quit Omnigraffle and restart ... "significant" changes) and the OS saves the state of which apps are open. ...
    (uk.comp.sys.mac)