Re: 2.6.17-rc5-mm1


* Andrew Morton <akpm@xxxxxxxx> wrote:

Without having looked at it very hard, I'd venture that this is a
false positive - that driver uses disable_irq() to prevent reentry
onto that lock.

correct.

It does that because it knows it's about to spend a long time talking
with the mii registers and it doesn't want to do that with interrupts
disabled.

i still consider it a 'quirky' locking construct, because disabling
interrupts for a long time also disables all other devices sharing the
same IRQ line - not nice.

Also, this is a really hard case for lockdep to detect automatically.
(fortunately it's also relatively rare)

OTOH, the straightforward lockdep workaround would be to take the
spinlock and thus disable all local interrupts - not too nice either.

Albeit in some ways it's still a bit nicer conceptually than disabling
the irq line, because other CPUs are still operational, and under
certain locking designs [preempt-rt] spin_lock_irq() does not disable
local interrupts.

Steve, can you think of any better solution? I dont have this card.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: sony vaio pcg-gr390
    ... PCI-Only Interrupts: none ... Location Bus Device Pin Link IRQs ... penalty: 1050 ... isa_probe_children: disabling PnP devices ...
    (freebsd-current)
  • Re: [RFC/PATCH] Kdump: Disabling PCI interrupts in capture kernel
    ... I know very little about consoles and their working. ... >> console driver needed interrupts to be enabled at the controller. ... looking at disabling the DMA from the devices. ... interrupt disable bit in PCI-PCI bridge is optional and if implemented, ...
    (Linux-Kernel)
  • Re: [RFC] mmiotrace full patch, preview 1
    ... the "first" probe gets selected and executed. ... kmmio_handler, where-ever it was triggered, executes with interrupts ... enable single-stepping. ... or does disabling interrupts guarantee that? ...
    (Linux-Kernel)
  • Re: IIgs Debuggers?
    ... Are you directly disabling any interrupts? ... I do disable interrupts on the initial loading of the wavebank into the DOC RAM, but I do so *exactly* as you have mentioned. ... I deliberately chose MIDI Synth sequences that all share the same instruments and wavebank file - thereby eliminating the need to reload them. ...
    (comp.sys.apple2.programmer)
  • Re: [patch 00/10] [RFC] SLUB patches for more functionality, performance and maintenance
    ... As far as I know the IA64 cmpxchg cannot do that. ... enable interrupts disable interrupts local CMPXCHG ... A cmpxchg allows us to avoid disabling and enabling interrupts. ... Test local cmpxchg vs int disable/enable. ...
    (Linux-Kernel)