Re: [PATCH 1/2] iWARP Connection Manager.



+ cm_id_priv = kzalloc(sizeof *cm_id_priv, GFP_KERNEL);

Please put paren's after sizeof, it is not required by C but it
is easier to read.

I disagree -- I hate seeing sizeof look like a function call.

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH] fix bogus hotplug cpu warning
    ... Hugh Dickins wrote: ... I don't see which part of the description you disagree with, ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • [PATCH] [1/8] CPA: Remove my copyright notice
    ... Not much left from the original code and I don't want my name ... on it because there is code in there I disagree with. ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option
    ... 30 Jun 2009 04:01:03 pm Pavel Machek wrote: ... I disagree with this: given there's been testing with no known issues, ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu scheduler
    ... I suspect Linus will disagree, especially if it never was in mm first ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver
    ... Also, I disagree with the: ... Probably this part of the chip should be programmed ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)